Relax tenant id format #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit relaxes the tenant id format so that it can begin with a lowercase letter or number. Previously, it was required to start with a lowercase number.
AloisReitbauer
approved these changes
Jul 25, 2019
mtwo
approved these changes
Jul 30, 2019
danielkhan
approved these changes
Jul 30, 2019
Closed
| lcalpha = %x61-7A ; a-z | ||
| ``` | ||
|
|
||
| **Note**: Identifiers MUST begin with a lowercase letter, and can only contain lowercase letters (`a`-`z`), digits (`0`-`9`), underscores (`_`), dashes (`-`), asterisks (`*`), and forward slashes (`/`). | ||
| **Note**: Identifiers MUST begin with a lowercase letter or a digit, and can only contain lowercase letters (`a`-`z`), digits (`0`-`9`), underscores (`_`), dashes (`-`), asterisks (`*`), and forward slashes (`/`). |
There was a problem hiding this comment.
I was trying to wrap my head around this and think there's a doc glitch here.
this phrase 'or a digit' here should apply both to simple and multi-tenant encodings. However, line 279 wasn't updated so basically the text doesn't match the abnf.
I think either the relaxing should apply in both abnf (ex also 279) or this special case about "or a digit" should move to the next paragraph which talks about the second encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relaxes the tenant id format so that it can begin with a lowercase letter or number. Previously, it was required to start with a lowercase letter. This change was discussed in issue #316.
My BNF-fu might not be quite up to snuff, so please double check it and let me know if it needs any adjustments.