Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR Request for W3C TraceContext Level 2 Specification #495

Closed
kalyanaj opened this issue Mar 28, 2023 · 13 comments
Closed

CR Request for W3C TraceContext Level 2 Specification #495

kalyanaj opened this issue Mar 28, 2023 · 13 comments
Assignees
Labels
Awaiting Publication Approved by the Director, waiting on publication Entering CR First Candidate Recommendation wg:distributed-tracing

Comments

@kalyanaj
Copy link

Document title, URLs, estimated publication date

Title: Trace Context Level 2
URL: https://w3c.github.io/trace-context/ (latest editors' draft)
Estimated publication date: After approval (no other strong deadline).

Abstract

This specification defines standard HTTP headers and a value format to propagate context information that enables distributed tracing scenarios. The specification standardizes how context information is sent and modified between services. Context information uniquely identifies individual requests in a distributed system and also defines a means to add and propagate provider-specific context information.

Status

Level 1 of this specification is already in Recommendation status since 2019. This is a minor incremental update to it called Trace Context Level 2:
https://w3c.github.io/trace-context/ (latest editor's draft)
https://www.w3.org/TR/trace-context-2/ (FPWD)

Link to group's decision to request transition

We discussed this in the Distributed Tracing WG meeting on 03/28/2023. The group unanimously decided to request this transition. Meeting notes are at: https://docs.google.com/document/d/1EaY1zhmlOut4qZzpFue4vLc96_GrRWMtmzXYLfd1Ehc/edit#.

Changes

The main changes are:

  • It introduces a new "flag" in the traceparent header called the random-trace-id flag. This is to indicate if the trace-id was generated randomly (or pseudo-randomly).
  • If the random-trace-id flag is set, at least the right-most 7 bytes of the trace-id MUST be randomly (or pseudo-randomly) generated.

Requirements satisfied

No specific requirements document was created.

Dependencies met (or not)

Please see next section.

Wide Review

Yes the wide review was done (w3c/trace-context#492) and issues have been addressed.

Issues addressed

Formal Objections

None so far

Implementation

open-telemetry/oteps#226 is an OpenTelemetry sampler specification enhancement proposal that references the above specification.
Minimum CR duration: 3 months
Exit criteria: At least 2 implementations adopting this specification and making use of it. The test suite will be updated as well.

Patent disclosures

None

@kalyanaj kalyanaj added [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. Entering CR First Candidate Recommendation labels Mar 28, 2023
@ylafon
Copy link
Member

ylafon commented Mar 31, 2023

Hi @kalyanaj
Looking at the diff from the FPWD and the editor's draft linked, I see the whole section 4 Trace Context HTTP Response Headers Format as not been reviewed.
Could you clarify?
Thanks

@ylafon ylafon added Awaiting Team Contact Awaiting Working Group This includes editors and team contacts and removed [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. labels Mar 31, 2023
@plehegar
Copy link
Member

we have a dedicated branch for level-2. I'll generate a WD for it to make it clear which document should be published as CR.

@ylafon
Copy link
Member

ylafon commented Apr 3, 2023

I would note also that I found a TAG review of the Trace Context Level 2 changes, so the diff from v1 REC to v2 FPWD, but not the review of Trace Context Level 1. Did that happen, or what is missed?

@plehegar
Copy link
Member

plehegar commented Apr 5, 2023

I created a snapshot of the level 2 branch:

@plehegar
Copy link
Member

plehegar commented Apr 5, 2023

I could not locate a formal TAG review request in late 2018.

I did find minutes from TPAC 2018, which include discussion on structured headers.

@plehegar
Copy link
Member

plehegar commented Apr 5, 2023

See also w3c/trace-context#197 (comment)

@ylafon
Copy link
Member

ylafon commented Apr 6, 2023

I could not locate a formal TAG review request in late 2018.

I did find minutes from TPAC 2018, which include discussion on structured headers.

That document is private

@plehegar
Copy link
Member

plehegar commented Apr 6, 2023

Also published a WD: https://www.w3.org/TR/2023/WD-trace-context-2-20230406/

@plehegar
Copy link
Member

plehegar commented Apr 6, 2023

I could not locate a formal TAG review request in late 2018.
I did find minutes from TPAC 2018, which include discussion on structured headers.

That document is private

:(

Fixed.

@plehegar plehegar added [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. and removed Awaiting Team Contact Awaiting Working Group This includes editors and team contacts labels Apr 6, 2023
@plehegar plehegar assigned ylafon and unassigned plehegar Apr 6, 2023
@plehegar
Copy link
Member

plehegar commented Apr 7, 2023

SOTD for CR:
[[
This new version adds considerations for the generation of the trace-id and span-id fields, and adds the random trace ID flag.

This document was published by the Distributed Tracing Working Group as a Candidate Recommendation Snapshot using the Recommendation track.
Publication as a Candidate Recommendation does not imply endorsement by W3C and its Members. A Candidate Recommendation Snapshot has received wide review, is intended to gather implementation experience, and has commitments from Working Group members to royalty-free licensing for implementations.
This Candidate Recommendation is not expected to advance to Proposed Recommendation any earlier than 07 July 2023.

The Working Group instends to demonstrate at least 2 implementations adopting this specification and making use of it, using a test suite.

This document was produced by a group operating under the 1 August 2017 W3C Patent Policy. W3C maintains a public list of any patent disclosures made in connection with the deliverables of the group; that page also includes instructions for disclosing a patent. An individual who has actual knowledge of a patent which the individual believes contains Essential Claim(s) must disclose the information in accordance with section 6 of the W3C Patent Policy.
This document is governed by the 2 November 2021 W3C Process Document.
]]

@ylafon
Copy link
Member

ylafon commented Apr 7, 2023

Thanks for the clarifications and new document published.
Transition is approved.

@ylafon ylafon added Awaiting Publication Approved by the Director, waiting on publication and removed [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. labels Apr 7, 2023
@plehegar plehegar assigned plehegar and unassigned ylafon Apr 7, 2023
@plehegar
Copy link
Member

@plehegar
Copy link
Member

plehegar commented May 1, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Publication Approved by the Director, waiting on publication Entering CR First Candidate Recommendation wg:distributed-tracing
Projects
None yet
Development

No branches or pull requests

4 participants