Make it clear that track IDs don't match on send and receive side #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fippo
approved these changes
Nov 8, 2018
jan-ivar
approved these changes
Nov 8, 2018
webrtc.html
Outdated
| <code><a>RTCRtpReceiver</a></code> will only have a single track, | ||
| potentially representing multiple sources of media stiched together. Thus | ||
| it's more accurate to think of a 1:1 relationship between an | ||
| potentially representing multiple sources of media stiched together. Both |
| <code><a data-link-for="RTCPeerConnection">addTransceiver</a></code> and | ||
| <code><a data-link-for="RTCRtpSender">replaceTrack</a></code> can be used to | ||
| cause the same track to be sent multiple times, which will be observed on | ||
| the receiver side as multiple receivers each with its own separate track. |
There was a problem hiding this comment.
s/can be/may be/ and s/will be/may be/ ?
This sentence seems a bit confusing when I read it. We should be careful not to give the mistaken impression that replaceTrack by itself somehow creates multiple receivers, which is true only for addTransceiver.
Even better, maybe remove replaceTrack from this sentence and explain it separately?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2005
Preview | Diff