Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rcnn #521

Merged
merged 4 commits into from
May 7, 2021
Merged

update rcnn #521

merged 4 commits into from
May 7, 2021

Conversation

freedenS
Copy link
Contributor

@freedenS freedenS commented May 1, 2021

  • fix bugs with R18 and R34
    add BasicBlock for R18 and R34
    add STRIDE_IN_1X1, MakeStage is same with detectron2 now.

  • update README.md

* add MaskRcnnInference plugin for mask selecting

* split ROIHeads to BOXHead and MaskHead

* remove unuseful parameters in createEngine_rcnn and BuildRcnnModel

* change the type of scores_h, boxes_h and classes_h from unique_ptr to vector

* add doInference

* add maskrcnn postprocess

* update README.md
* fix bugs with R18 and R34
 add BasicBlock for R18 and R34
 add STRIDE_IN_1X1, MakeStage is same with detectron2 now.

* update README.md
Copy link
Owner

@wang-xinyu wang-xinyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个图片可以删掉然后提供一个下载链接吗?因为想保持repo size尽量小

@freedenS
Copy link
Contributor Author

freedenS commented May 6, 2021

No problem! 😊

replace picture with url
@wang-xinyu wang-xinyu merged commit 2c4fdea into wang-xinyu:master May 7, 2021
@JiHooooo
Copy link

JiHooooo commented Jun 2, 2021

Thanks for your excellent work!!!
I want to know whether the code can be run under CUDA11.1?
It looks like that the folder [thrust/system/cuda/detail/cub/device/] has been deleted in CUDA11.1.

@freedenS
Copy link
Contributor Author

freedenS commented Jun 3, 2021

@JiHooooo we just use cub library, maybe you can find it in cuda-11.1/include/cub
if not, you can also download from https:/NVIDIA/cub

@freedenS freedenS mentioned this pull request Jun 21, 2021
@Dorozhko-Anton
Copy link

Dorozhko-Anton commented Jun 21, 2021

@freedenS to build rcnn with CUDA 11 I had to modify the following files

 modified:   ../BatchedNms.cu
 modified:   ../PredictorDecode.cu
        modified:   ../RpnDecode.cu
        modified:   ../RpnNms.cu
  1. change CMakeLists.txt
include_directories(/usr/local/cuda/include/cub)
  1. I changed the includes
//#include <thrust/system/cuda/detail/cub/device/device_radix_sort.cuh>
#include <cub/device/device_radix_sort.cuh>
  1. Then I had to change thrust::cuda_cub::cub:: to cub::

@freedenS
Copy link
Contributor Author

@freedenS to build rcnn with CUDA 11 I had to modify the following files

 modified:   ../BatchedNms.cu
 modified:   ../PredictorDecode.cu
        modified:   ../RpnDecode.cu
        modified:   ../RpnNms.cu
  1. change CMakeLists.txt
include_directories(/usr/local/cuda/include/cub)
  1. I changed the includes
//#include <thrust/system/cuda/detail/cub/device/device_radix_sort.cuh>
#include <cub/device/device_radix_sort.cuh>
  1. Then I had to change thrust::cuda_cub::cub:: to cub::

yes, that's it!

@rgkannan676 rgkannan676 mentioned this pull request Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants