Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random port banding failure #222

Open
baobo5625 opened this issue Nov 10, 2018 · 3 comments
Open

Random port banding failure #222

baobo5625 opened this issue Nov 10, 2018 · 3 comments
Labels

Comments

@baobo5625
Copy link

https:/wangyu-/udp2raw-tunnel/blob/b1f0498472b644457d3588f90bde34b4338608dc/network.cpp#L2546

The application exit due to port binding failure.
I think the port was used serving other traffic, 1000 time trying won't last that long for the port to be released.

I think for the 1000 times trying, maybe we could use different random port instead of same random port?
Which means to move the port calculation into the loop instead of ouside the loop.

Thoughts?

@wangyu-
Copy link
Owner

wangyu- commented Nov 13, 2018

I think you are right. The port calculation was meant to be inside the loop, I cant believe I have put it outside😂

@baobo5625
Copy link
Author

baobo5625 commented Nov 13, 2018 via email

@wangyu-
Copy link
Owner

wangyu- commented Nov 13, 2018

I already fixed and commited it a few minutes ago, will post a new release later.

Thank you very much.

@wangyu- wangyu- added the bug label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants