-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random port banding failure #222
Labels
Comments
I think you are right. The port calculation was meant to be inside the loop, I cant believe I have put it outside😂 |
yea, i'm suffering from this issue and almost would like to fork and change
myself.
I'll submit an MR once I'm available but it would be great if you could
update it from master repo.
bo
wangyu- <[email protected]> 于2018年11月13日周二 下午4:21写道:
… I think you are right. The port calculation was meant to be inside the
loop, I cant believe I have put it outside😂
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https:/wangyu-/udp2raw-tunnel/issues/222#issuecomment-438176739>,
or mute the thread
<https:/notifications/unsubscribe-auth/AAFenig3XDwHxYt3Qg5c1T-LZVbXEv3Lks5uuoDxgaJpZM4YYEKi>
.
|
I already fixed and commited it a few minutes ago, will post a new release later. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https:/wangyu-/udp2raw-tunnel/blob/b1f0498472b644457d3588f90bde34b4338608dc/network.cpp#L2546
The application exit due to port binding failure.
I think the port was used serving other traffic, 1000 time trying won't last that long for the port to be released.
I think for the 1000 times trying, maybe we could use different random port instead of same random port?
Which means to move the port calculation into the loop instead of ouside the loop.
Thoughts?
The text was updated successfully, but these errors were encountered: