-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for remapstart #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a way to organise I'd say it should:
- check if a start section is present. If not, just quit.
- check if an export named
main
exists. If yes, start (recursively) rename so that there is nomain
function. - insert a new export called
main
which points to the same function index what the start section was using - remove the start section
Already implemented as described.
I have a comment in the code because I wasn't sure whether to expect the module to be validly formed when Also, I'm not sure that implementing this with recursion is much cleaner than what I am currently doing?
Already implemented as described.
Already implemented as described. |
Lets simplify my last comment #107 (review): As a way to organise I'd say it should:
|
@jwasinger can you squash this to a single commit? |
4bce354
to
9a9a94d
Compare
d829efb
to
2709bfe
Compare
4755482
to
806fd2e
Compare
Fixes #99