Rename re-exported Module to WasmModule for clarity #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakelang
reviewed
Sep 19, 2019
libchisel/src/lib.rs
Outdated
| @@ -3,7 +3,7 @@ extern crate binaryen; | |||
| extern crate parity_wasm; | |||
| extern crate rustc_hex; | |||
|
|
|||
| pub use parity_wasm::elements::Module; | |||
| use parity_wasm::elements::Module; | |||
There was a problem hiding this comment.
Can do pub use parity_wasm::elements::Module as WasmModule if we also rename it in the rest of the codebase, which would have the side effect of making all the other code more readable.
axic
force-pushed
the
wasm-module
branch
2 times, most recently
from
e056643
to
5bec089
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159.