Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wazuh Handler: Create, delete assign and unassign groups to agents #60

Closed
pro-akim opened this issue Jun 16, 2023 · 17 comments · Fixed by #71
Closed

Wazuh Handler: Create, delete assign and unassign groups to agents #60

pro-akim opened this issue Jun 16, 2023 · 17 comments · Fixed by #71

Comments

@pro-akim
Copy link
Member

pro-akim commented Jun 16, 2023

Description

Develop for qa-system-framework in WazuhHandler

  • Method to create and delete groups.
    It should include: via API, via CMD, via deleting or creating a directory, if it is possible.
    Consider a method to create and delete groups individually, as well as create and delete groups through a list of groups.

  • Method to assign and unassign agents to groups:
    It should include: via API, via CMD, via deleting or creating a directory, if it is possible.
    It should include assigning and unassigning agents to groups individually, as well as receiving a list of agents for a group.

Created methods

  • wazuh_handler.create_group()

method: cmd/api

  • wazuh_handler.delete_group()

method: cmd/api/folder

  • wazuh_handler.assign_agent_group()

method: cmd/api

  • wazuh_handler.assign_agents_group()

method: cmd/api

  • wazuh_handler.unassign_agent_group()

method: api

  • wazuh_handler.unassign_agents_group()

method: api

  • wazuh_handler,check_agent_groups()

method: cmd

@pro-akim pro-akim self-assigned this Jun 16, 2023
pro-akim added a commit that referenced this issue Jun 28, 2023
@pro-akim
Copy link
Member Author

pro-akim commented Jun 28, 2023

28/06/2023

Creation of mentioned methods were performed.
After developing methods, PR was done.
Some methods does not have API or Folder method.

@pro-akim pro-akim linked a pull request Jun 28, 2023 that will close this issue
@pro-akim
Copy link
Member Author

Update

Checking review.

pro-akim added a commit that referenced this issue Jul 21, 2023
pro-akim added a commit that referenced this issue Jul 21, 2023
@pro-akim
Copy link
Member Author

pro-akim commented Jul 21, 2023

Update

Most of the fixes were performed. However, it will be needed to have some team communication in order to define 'validations' in each method.
The status of the issue is changed to On hold

@pro-akim
Copy link
Member Author

pro-akim commented Jul 24, 2023

Update

Will be added a parameter that allows to check previous existence (agent assigned to groups or groups)

@pro-akim
Copy link
Member Author

Update

Parameters successfully added, Tests OK
Ready to review

@pro-akim
Copy link
Member Author

Update

PR was not pushed correctly.

@pro-akim
Copy link
Member Author

Update

Changes are done, but Linter is not working properly, the last commit was just a linting correction but the message is wrong.
Ready to review

@pro-akim
Copy link
Member Author

pro-akim commented Aug 4, 2023

Update

Moved to on hold for task with higher priorities

@pro-akim
Copy link
Member Author

pro-akim commented Aug 9, 2023

Update

Moved to on hold for task with higher priorities

@pro-akim
Copy link
Member Author

Update

Moved to on hold for task with higher priorities

1 similar comment
@pro-akim
Copy link
Member Author

Update

Moved to on hold for task with higher priorities

pro-akim added a commit that referenced this issue Aug 22, 2023
@pro-akim
Copy link
Member Author

Fixes done.

Moved to pending review.
Linter is pointing out, lines that does not show conflicts.

@pro-akim
Copy link
Member Author

Update

Some small changes were done after linter (replacement of " for ') and parameters of 'get_agents_id' method and 'get_agent_id', documentation fixed.

@pro-akim
Copy link
Member Author

Update

Some conflicts have been raised. Fixing them

pro-akim added a commit that referenced this issue Nov 15, 2023
pro-akim added a commit that referenced this issue Nov 16, 2023
@Rebits
Copy link
Member

Rebits commented Nov 21, 2023

Delayed ETA to 22, in order to allow a review of the applied changes

pro-akim added a commit that referenced this issue Nov 22, 2023
@pro-akim
Copy link
Member Author

Update

Fixes done after review.

pro-akim added a commit that referenced this issue Nov 22, 2023
@davidjiglesias
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants