Validate the agent name field in the "Deploy a new agent" section

[s-ocando]

Wazuh	Rev
4.4.0	4400

Description

Currently, the app allows agent names that are not valid. This causes the enrollment to fail.

The app must validate that the agent name has the minimum required length and that it contains only allowed characters.

In this example, I installed a 4.4.0 agent named "SALES DEPARTMENT" on Ubuntu 20.04 following the instructions from the UI. The installation worked without failure. The agent was active but I was unable to see it in the console.

I checked /var/ossec/logs/ossec.log and saw the message ERROR: Invalid agent name. Please pick a valid name. I changed the name to "SALES", restarted the agent and it enrolled successfully.

vagrant@wazuh-agent:~$ curl -so wazuh-agent-4.4.0.deb https://packages-dev.wazuh.com/staging/apt/pool/main/w/wazuh-agent/wazuh-agent_4.4.0-0.40400.20221116_amd64.deb && sudo WAZUH_MANAGER='192.168.56.44' WAZUH_AGENT_NAME='SALES DEPARTMENT' dpkg -i ./wazuh-agent-4.4.0.deb
Selecting previously unselected package wazuh-agent.
(Reading database ... 111293 files and directories currently installed.)
Preparing to unpack ./wazuh-agent-4.4.0.deb ...
Unpacking wazuh-agent (4.4.0-0.40400.20221116) ...
Setting up wazuh-agent (4.4.0-0.40400.20221116) ...
Processing triggers for systemd (245.4-4ubuntu3.15) ...
vagrant@wazuh-agent:~$ sudo systemctl daemon-reload
vagrant@wazuh-agent:~$ sudo systemctl enable wazuh-agent
Synchronizing state of wazuh-agent.service with SysV service script with /lib/systemd/systemd-sysv-install.
Executing: /lib/systemd/systemd-sysv-install enable wazuh-agent
Created symlink /etc/systemd/system/multi-user.target.wants/wazuh-agent.service → /lib/systemd/system/wazuh-agent.service.
vagrant@wazuh-agent:~$ sudo systemctl start wazuh-agent
vagrant@wazuh-agent:~$ systemctl status wazuh-agent
vagrant@wazuh-agent:~$ systemctl status wazuh-agent
● wazuh-agent.service - Wazuh agent
     Loaded: loaded (/lib/systemd/system/wazuh-agent.service; enabled; vendor preset: enabled)
     Active: active (running) since Mon 2022-11-28 09:50:15 UTC; 3min 11s ago
    Process: 3051 ExecStart=/usr/bin/env /var/ossec/bin/wazuh-control start (code=exited, status=0/SUCCESS)
      Tasks: 27 (limit: 1148)
     Memory: 109.2M
     CGroup: /system.slice/wazuh-agent.service
             ├─3083 /var/ossec/bin/wazuh-execd
             ├─3091 /var/ossec/bin/wazuh-agentd
             ├─3101 /var/ossec/bin/wazuh-syscheckd
             ├─3110 /var/ossec/bin/wazuh-logcollector
             └─3127 /var/ossec/bin/wazuh-modulesd

Nov 28 09:50:11 wazuh-agent systemd[1]: Starting Wazuh agent...
Nov 28 09:50:11 wazuh-agent env[3051]: Starting Wazuh v4.4.0...
Nov 28 09:50:11 wazuh-agent env[3051]: Started wazuh-execd...
Nov 28 09:50:11 wazuh-agent env[3051]: Started wazuh-agentd...
Nov 28 09:50:11 wazuh-agent env[3051]: Started wazuh-syscheckd...
Nov 28 09:50:12 wazuh-agent env[3051]: Started wazuh-logcollector...
Nov 28 09:50:13 wazuh-agent env[3051]: Started wazuh-modulesd...
Nov 28 09:50:15 wazuh-agent env[3051]: Completed.
Nov 28 09:50:15 wazuh-agent systemd[1]: Started Wazuh agent.

root@wazuh-agent:/home/vagrant# tail /var/ossec/logs/ossec.log 
2022/11/28 09:51:26 wazuh-agentd: ERROR: Invalid agent name "SALES DEPARTMENT". Please pick a valid name.
2022/11/28 09:51:56 wazuh-agentd: INFO: Requesting a key from server: 192.168.56.44

[davidjiglesias]

Agreed with @s-ocando suggestion. I would add that group name also need validation.

[Tostti]

Hi @davidjiglesias, thanks for the recommendation.
However, the groups are selected from the already created groups in Wazuh, it is not possible to create new groups from the deploy new agent section.
From the groups section, it is currently not possible to create a group with an invalid name.

[Desvelao]

Changes

• Add validation for the characters length and valid characters