Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix architecture link in the deploy agent wizard #4880

Merged
merged 11 commits into from
Nov 17, 2022

Conversation

chantal-kelm
Copy link
Member

Description

Raspbian OS, commands in the wizard deploy agent now change when selecting a different architecture.

Issues Resolved

[#4204]

Evidence

[image

Steps to test:

*Go to the Agents tab
*Click on the 'Deploy new agent' button.
*Verify that when changing architecture the OS Raspbian, show the commands according to the selected architecture.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm requested a review from a team as a code owner November 17, 2022 11:35
Machi3mfl
Machi3mfl previously approved these changes Nov 17, 2022
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Peek.2022-11-17.09-44.mp4

@chantal-kelm chantal-kelm linked an issue Nov 17, 2022 that may be closed by this pull request
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Video.sin.titulo.mp4

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related:

Same problem appears to be in Debian.
Evidence:
image
image

CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.69% ( 3210 / 36959 )
Branches 4.43% ( 1271 / 28685 )
Functions 7.59% ( 696 / 9167 )
Lines 8.75% ( 3097 / 35379 )

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chantal-kelm chantal-kelm merged commit 80fceb3 into 4.4-7.10 Nov 17, 2022
@chantal-kelm chantal-kelm deleted the fix-link-of-architecture branch November 17, 2022 16:14
github-actions bot pushed a commit that referenced this pull request Nov 17, 2022
* link of architecture

* CHANGELOG

* restore branch

* fix link raspbian

* space

* CHANGELOG

* debian link

* CHANGELOG

(cherry picked from commit 80fceb3)
chantal-kelm added a commit that referenced this pull request Nov 17, 2022
…rd (#4882)

Fix architecture link in the deploy agent wizard (#4880)

* link of architecture

* CHANGELOG

* restore branch

* fix link raspbian

* space

* CHANGELOG

* debian link

* CHANGELOG

(cherry picked from commit 80fceb3)

Co-authored-by: Chantal Belén kelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update agent installation command for all agents
4 participants