Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.4-7.16] Fix the agent installation command for macOS #4983

Merged
merged 5 commits into from
Dec 19, 2022
Merged

[Backport 4.4-7.16] Fix the agent installation command for macOS #4983

merged 5 commits into from
Dec 19, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 13, 2022 •
edited
Loading

Backport [262440c, 36aca38, dccafa0, f8e5402, b882b9d] from #4968.

@chantal-kelm chantal-kelm requested a review from a team as a code owner December 13, 2022 12:19
@chantal-kelm chantal-kelm mentioned this pull request Dec 13, 2022
Merged
6 tasks
@chantal-kelm chantal-kelm changed the title Fixed the agent installation command for macOS [Backport 4.4-7.16] Fix the agent installation command for macOS Dec 13, 2022
@chantal-kelm chantal-kelm self-assigned this Dec 13, 2022
@chantal-kelm chantal-kelm linked an issue Dec 13, 2022 that may be closed by this pull request
macOS agent installation command fails due to launchctl setenv #4953
Closed
@chantal-kelm chantal-kelm changed the title [Backport 4.4-7.16] Fix the agent installation command for macOS [Backport 4.4-7.16] Fixed the agent installation command for macOS Dec 14, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-7.16] Fixed the agent installation command for macOS [Backport 4.4-7.16] Fix the agent installation command for macOS Dec 14, 2022
Mayons95
Mayons95 approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️

LGTM

Screenshot from 2022-12-16 15-44-02

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.49% ( 3211 / 37833 )
Branches 4.36% ( 1273 / 29219 )
Functions 7.4% ( 696 / 9407 )
Lines 8.56% ( 3098 / 36180 )

@chantal-kelm chantal-kelm merged commit a389dc0 into 4.4-7.16 Dec 19, 2022
@chantal-kelm chantal-kelm deleted the backport-4968-to-4.4-7.16 branch December 19, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayons95 Mayons95 Mayons95 approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

macOS agent installation command fails due to launchctl setenv
3 participants
@chantal-kelm @Mayons95 @AlexRuiz7