Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-7.16] Added file saving conditions in File Editor #5002

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport ec10fc7 from #4970.

* Added Rule editor validation

* Updated CHANGELOG

Co-authored-by: Álex <[email protected]>
(cherry picked from commit ec10fc7)
@github-actions github-actions bot requested a review from a team as a code owner December 15, 2022 16:34
@Machi3mfl Machi3mfl self-assigned this Dec 15, 2022
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing ✔️

@Desvelao Desvelao linked an issue Dec 16, 2022 that may be closed by this pull request
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

✔️ code
✔️ test

Screenshots
image

@Desvelao Desvelao merged commit 376e404 into 4.4-7.16 Dec 16, 2022
@Desvelao Desvelao deleted the backport-4970-to-4.4-7.16 branch December 16, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError if empty rule is created
2 participants