Implement new versioning methodology #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
AlexRuiz7
approved these changes
Jan 4, 2023
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
* change code stage * change revision number * add commit property * add test * add script tags * Update tag.py script to support multiple platforms * Add prebuild task to Makefile Co-authored-by: Alex Ruiz Becerra <[email protected]> (cherry picked from commit 128a487)
github-actions bot
pushed a commit
that referenced
this pull request
Jan 5, 2023
* change code stage * change revision number * add commit property * add test * add script tags * Update tag.py script to support multiple platforms * Add prebuild task to Makefile Co-authored-by: Alex Ruiz Becerra <[email protected]> (cherry picked from commit 128a487)
yenienserrano
added a commit
that referenced
this pull request
Jan 5, 2023
Implement new versioning methodology (#5060) * change code stage * change revision number * add commit property * add test * add script tags * Update tag.py script to support multiple platforms * Add prebuild task to Makefile Co-authored-by: Alex Ruiz Becerra <[email protected]> (cherry picked from commit 128a487) Co-authored-by: Ian Yenien Serrano <[email protected]>
yenienserrano
added a commit
that referenced
this pull request
Jan 5, 2023
Implement new versioning methodology (#5060) * change code stage * change revision number * add commit property * add test * add script tags * Update tag.py script to support multiple platforms * Add prebuild task to Makefile Co-authored-by: Alex Ruiz Becerra <[email protected]> (cherry picked from commit 128a487) Co-authored-by: Ian Yenien Serrano <[email protected]>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the
package.jsonsettings were changed,for example:
version: untouched. Follows the major.minor.patch patternrevision: represents the build number. It is a number of 2 digits, starting at 00 and increased by one each time a package for the same version is built. This value is reset only when the version changes.stage: replaces the code property which has no actual use. With this property, we'll represent the stage of development at which the package has been built at: pre-alpha (development), alpha, beta, release-candidate or stable (production).commit: we'll also include the short SHA of the latest commit included in the package (can also be the SHA of the commit used to tag). With this, we'll be able to have a clear reference of what was included in the package.Tests were added to corroborate the correctness of these settings.
Also, a script to generate the tags automatically has been added.
Issues Resolved
Evidence
Test
Check that the
package.jsoncontains the settings:versionrevisionstagecommitVerify that the tests are working and if you change the value of these settings to invalid values, the tests will not work.
package.test.tsCheck List
yarn test:jest