Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.4-7.10] Fix error when clicking on the multiple agent selector #5096

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Desvelao
Copy link
Member

@Desvelao Desvelao commented Jan 10, 2023

Description

This pull request fixes a console error displayed when clicking in the multiple agent selector to manage the agents in a group

Issues Resolved

Closes #5091

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

Scenario 1 Clicking on the multiple selector (Available agents) of the group agents management doesn't display any error in the console of the browser dev tools
Given a group without agents
When the user goes to Manage agents
And clicking on selector of the Available agentsCurrent agents in the group panel
Then it should not appear an error in the console of the browser dev tools

Scenario 2 Clicking on the multiple selector (Current agents in the group) of the group agents management doesn't display any error in the console of the browser dev tools
Given a group without agents
When the user goes to Manage agents
And clicking on selector of the Current agents in the group panel
Then it should not appear an error in the console of the browser dev tools

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* fix(): fix console error when clicking in multiple agents selector

* changelog: add entry

Co-authored-by: Federico Rodriguez <[email protected]>
(cherry picked from commit c107045)
@Desvelao Desvelao requested a review from a team as a code owner January 10, 2023 13:19
@Desvelao Desvelao self-assigned this Jan 10, 2023
@Desvelao Desvelao linked an issue Jan 10, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.78% ( 3248 / 37009 )
Branches 4.54% ( 1306 / 28738 )
Functions 7.66% ( 703 / 9172 )
Lines 8.84% ( 3133 / 35436 )

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@yenienserrano yenienserrano merged commit 0b54677 into 4.4-7.10 Jan 10, 2023
@yenienserrano yenienserrano deleted the backport-5094-to-4.4-7.10 branch January 10, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error adding a single agent into a group
2 participants