Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vulnerabilities dashboards] Fix vulnerability dashboard filters #6065

Conversation

jbiset
Copy link
Member

@jbiset jbiset commented Oct 27, 2023

Description

This PR, fixes a bug in the filters of the vulnerabilities dashboard when a filter is applied in the search bar.

Issues Resolved

Closes #6064

Evidence

Evidence.webm

Test

  1. Navigate to Modules -> Vulnerabilities
  2. Click on an option in a filter on the dashboard
  3. See if filter options change based on the added filter

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@jbiset jbiset requested a review from a team as a code owner October 27, 2023 14:10
@jbiset jbiset linked an issue Oct 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.81% ( 4102 / 34718 )
Branches 7.99% ( 1872 / 23401 )
Functions 11.3% ( 940 / 8313 )
Lines 12% ( 3987 / 33208 )

Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Screen.Recording.2023-10-27.at.12.50.34.mov

@Machi3mfl Machi3mfl merged commit 73cd071 into feat/5763-global-vulnerabilities-dashboard Oct 27, 2023
2 checks passed
@Machi3mfl Machi3mfl deleted the 6064-fix-vulnerability-dashboard-filters branch October 27, 2023 15:51
asteriscos pushed a commit that referenced this pull request Nov 3, 2023
…5896)

* Added plugins dependencies

* Add new inventories tabs scaffolding

* Refactor arquitecture

* Add searchbar folder

* Add useDashboardConfiguration hook for configuring vulnerability dashboards (#5947)

* Add useDashboardConfiguration and unit test hook

* Changed how the initial hook configuration is set

* [Vulnerabilities dashboards] Add search bar services (#5960)

* Add search bar hooks

* Rename searchbar hook

* Add unit test to use search bar configuration hook

* Fix some unit test titles

* Remove console.log

* Solve requested changes

* Fix request changes and hook filename

* [Vulnerabilities dashboards] Fix wrong agent.id filters loaded in search bar by default (#5970)

Remove agent id filter in searchbar

* Change new vulnerabilities inventory table (#6047)

* Add data grid hook

* Add doc viewer component and hook

* Add ui utils components

* Add new vuls inventory component

* Add vuls inventory in module rendering

* Add full height container

* Add inventory table columns

* Remove columns fields filter by keyword type

* Feat/5894 vulnerabilities dashboard create the dashboard tab using osd plugins (#5966)

* Add useDashboardConfiguration and unit test hook

* Changed how the initial hook configuration is set

* Create dashboard using embedded visualizations by value.

* [Vulnerabilities dashboards] Add search bar services (#5960)

* Add search bar hooks

* Rename searchbar hook

* Add unit test to use search bar configuration hook

* Fix some unit test titles

* Remove console.log

* Solve requested changes

* Fix request changes and hook filename

* [Vulnerabilities dashboards] Fix wrong agent.id filters loaded in search bar by default (#5970)

Remove agent id filter in searchbar

* Recommended filters are added and communication problems between the dashboard and the searchbar are solved

* Update Vulnerability detector dashboard filters visualization and VULNERABILITIES_INDEX_PATTERN_ID constant

* Change KPI dashboard and fix bad request

* Separates filter panels from dashboard panels

* Add Accumulation of the most detected vulnerabilities visualization and change

---------

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fix default filters on usesearchbar configuration

* [Vulnerabilities dashboards] Fix vulnerability dashboard filters (#6065)

Fix vulnerability dashboard filters

* Remove date picker from searchbar on vuls inventory tab

* Remove date picker from searchbar and open vs close visualization on vuls dashboard tab

* Change Accumulation of the most detected vulnerabilities chart

* Add data grid csv export

* Add error management and export csv calls pagination

* Remove unused hook

* Update CHANGELOG

* Fix CHANGELOG

* Remove explore agent in header

---------

Co-authored-by: Julio César Biset <[email protected]>
Co-authored-by: jbiset <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Vulnerability Dashboards] Fix vulnerability dashboard filters
2 participants