Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix design implementation #6070

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented Oct 27, 2023

Description

  • In the About page delete the API table and leave a React component the same as the previous Angular template.
  • Delete unused components related to the About page.
  • In the UpdatesNotification component only ask for available updates if the user doesn't check "Disable update notifications".
  • In API Table handle check updates button errors and show a toast.

Issues Resolved

wazuh/wazuh-dashboard#96

Evidence

About page

image

Bottom bar notification

image

API Table

image

Updates status error message

image

Check updates button error

image

Test

  • Go to the About page and compare it to the current About page. They must be the same.
  • When the bottom bar notification appears, check Disable update notifications and click the Dismiss button. Reload the page and check the network requests. A request for user preferences (ending in /me) should appear, but there should not be a request for available updates (ending in /updates?checkAvailableUpdates=false).
  • Go to Settings -> API configuration. Disable the network connection and click on Check Updates button. A toast should appear with an error.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza linked an issue Oct 27, 2023 that may be closed by this pull request
7 tasks
@lucianogorza lucianogorza marked this pull request as ready for review October 30, 2023 17:43
@lucianogorza lucianogorza requested a review from a team as a code owner October 30, 2023 17:43
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.61% ( 4012 / 34528 )
Branches 7.74% ( 1808 / 23337 )
Functions 11.05% ( 913 / 8261 )
Lines 11.81% ( 3901 / 33031 )

@Tostti
Copy link
Member

Tostti commented Oct 31, 2023

Test

🟢 Go to the About page and compare it to the current About page. They must be the same.

image

🟢 When the bottom bar notification appears, check Disable update notifications and click the Dismiss button. Reload the page and check the network requests. A request for user preferences (ending in /me) should appear, but there should not be a request for available updates (ending in /updates?checkAvailableUpdates=false).

image

🟢 Go to Settings -> API configuration. Disable the network connection and click on Check Updates button. A toast should appear with an error.

image
image

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST:✔️
CR:✔️

LGTM

@asteriscos
Copy link
Member

API Settings Flyout

image

Error and tooltips

image

Check Updates button

image

About page and bottom bar

image

Dismiss notifications button

image

Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

@asteriscos asteriscos merged commit 36af078 into enhancement/84-update-check-service-ui Nov 2, 2023
2 checks passed
@asteriscos asteriscos deleted the enhancement/96-fix-design-implementation branch November 2, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix desing implementation
3 participants