Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for installing agents on macOS #6305

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Script for installing agents on macOS #6305

merged 5 commits into from
Jan 12, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jan 10, 2024 •
edited
Loading

Description

when using the password to install agents in macos, the installation script was generated incorrectly without space or &&

Issues Resolved

Evidence

image

Test

You need a real manage

  1. Set the password for deploy agent
  2. See that the macOS install command is rendered correctly

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano changed the base branch from master to 4.8.0 January 10, 2024 17:38
@yenienserrano yenienserrano linked an issue Jan 12, 2024 that may be closed by this pull request
Failure of script during Mac OS Agent deployment #6294
Closed
@yenienserrano yenienserrano self-assigned this Jan 12, 2024
@yenienserrano yenienserrano marked this pull request as ready for review January 12, 2024 09:28
@yenienserrano yenienserrano requested a review from a team as a code owner January 12, 2024 09:28
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.42% ( 186 / 868 )
Branches 17.99% ( 79 / 439 )
Functions 14.22% ( 36 / 253 )
Lines 21.65% ( 183 / 845 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.68% ( 171 / 223 )
Branches 57.57% ( 57 / 99 )
Functions 61.7% ( 29 / 47 )
Lines 76.68% ( 171 / 223 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.24% ( 4218 / 34433 )
Branches 8.31% ( 1923 / 23135 )
Functions 11.71% ( 958 / 8176 )
Lines 12.42% ( 4103 / 33024 )

@JuanGarriuz
Copy link
Member

LGTM!!
Evidence:
image

asteriscos
asteriscos approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

image

@asteriscos asteriscos merged commit ea3473f into 4.8.0 Jan 12, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6294-failure-of-script-during-mac-os-agent-deployment branch January 12, 2024 12:41
@asteriscos asteriscos mentioned this pull request May 29, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure of script during Mac OS Agent deployment
3 participants
@yenienserrano @JuanGarriuz @asteriscos