Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix server stat Archives queue usage is picking the wrong value #6342

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Fix server stat Archives queue usage is picking the wrong value #6342

merged 5 commits into from
Jan 19, 2024

Conversation

lucianogorza
Copy link
Contributor

@lucianogorza lucianogorza commented Jan 18, 2024 •
edited
Loading

Description

This PR fixes the Queue Usage stat. It was picking the max value instead of the current value in the visualization on the stats page.

Issues Resolved

#6340

Evidence

image

Test

  1. Navigate to Server management -> Statistics -> Analysis Engine tab
  2. Examine the Queue usage visualization

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@lucianogorza lucianogorza self-assigned this Jan 18, 2024
@lucianogorza lucianogorza marked this pull request as ready for review January 18, 2024 12:15
@lucianogorza lucianogorza requested a review from a team as a code owner January 18, 2024 12:15
@asteriscos asteriscos linked an issue Jan 18, 2024 that may be closed by this pull request
Server stat "Archives queue usage" is picking the wrong value #6340
Closed
@asteriscos asteriscos self-requested a review January 18, 2024 12:19
@yenienserrano yenienserrano self-requested a review January 19, 2024 10:33
asteriscos
asteriscos previously approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✔️
Test: ✔️

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.21% ( 4203 / 34420 )
Branches 8.26% ( 1911 / 23123 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4088 / 33012 )

yenienserrano
yenienserrano approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image

@asteriscos asteriscos merged commit 0c6b647 into 4.8.0 Jan 19, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6340-server-stat-archives-queue-usage-is-picking-the-wrong-value branch January 19, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@lucianogorza lucianogorza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server stat "Archives queue usage" is picking the wrong value
3 participants
@lucianogorza @asteriscos @yenienserrano