Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compilation date from dashboard #6366

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Remove compilation date from dashboard #6366

merged 3 commits into from
Jan 24, 2024

Conversation

asteriscos
Copy link
Member

Description

This pull request removes all uses of the compilation_date field, because these API endpoints will no longer contain the field:

GET /cluster/{node_id}/info
GET /manager/info

Issues Resolved

Closes #6365

Evidence

image

Test

  • Check the Compilation Date is no longer present in the Status view.
  • Check the compilation_date field is not used anywhere in the app

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Jan 23, 2024
@asteriscos asteriscos requested a review from a team as a code owner January 23, 2024 18:12
@asteriscos asteriscos changed the title Remove compilation date from dashboard 6365 Remove compilation date from dashboard Jan 23, 2024
@asteriscos asteriscos linked an issue Jan 23, 2024 that may be closed by this pull request
Remove compilation date from dashboard #6365
Closed
2 tasks
@lucianogorza lucianogorza self-requested a review January 23, 2024 19:34
lucianogorza
lucianogorza previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

Tostti
Tostti previously approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test

image

Test ✅
CR ✅

LGTM

@asteriscos asteriscos dismissed stale reviews from Tostti and lucianogorza via 9523e2d January 24, 2024 16:12
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 21.18% ( 186 / 878 )
Branches 17.99% ( 79 / 439 )
Functions 14% ( 36 / 257 )
Lines 21.4% ( 183 / 855 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.2% ( 4202 / 34418 )
Branches 8.25% ( 1908 / 23118 )
Functions 11.71% ( 958 / 8176 )
Lines 12.38% ( 4087 / 33011 )

Tostti
Tostti approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit e8d2d00 into 4.8.0 Jan 24, 2024
4 checks passed
@asteriscos asteriscos deleted the change/remove-compilation-date-from-dashboard-6365 branch January 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tostti Tostti Tostti approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove compilation date from dashboard
3 participants
@asteriscos @Tostti @lucianogorza