Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicated help menu #6374

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Fix duplicated help menu #6374

merged 4 commits into from
Jan 29, 2024

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Jan 24, 2024 •
edited
Loading

Description

This PR modifies the help menu, to be updated to the current requirements, and to avoid the inconsistency and duplication that occured previously

Issues Resolved

#6368

Evidence

image

Test

Verify that the help menu is the same being inside the Wazuh plugin and outside of it (for example, in Dashboard management).
Try to move from the Wazuh plugin to outside of it, and vice-versa and confirm that the menu doesn't change.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Tostti Tostti mentioned this pull request Jan 24, 2024
Closed
3 tasks
@Tostti Tostti marked this pull request as ready for review January 29, 2024 11:24
@Tostti Tostti requested a review from a team as a code owner January 29, 2024 11:24
@Tostti Tostti self-assigned this Jan 29, 2024
@lucianogorza lucianogorza self-requested a review January 29, 2024 12:15
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 57.42% ( 58 / 101 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

lucianogorza
lucianogorza approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.85% ( 186 / 892 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.05% ( 183 / 869 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.22% ( 4207 / 34425 )
Branches 8.28% ( 1918 / 23140 )
Functions 11.72% ( 959 / 8176 )
Lines 12.39% ( 4092 / 33018 )

@yenienserrano yenienserrano self-requested a review January 29, 2024 13:36
yenienserrano
yenienserrano approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

image
image

@Tostti Tostti merged commit 9a6611b into 4.8.0 Jan 29, 2024
4 checks passed
@Tostti Tostti deleted the 6368-fix-duplicate-help-menu branch January 29, 2024 13:42
@Tostti Tostti linked an issue Jan 29, 2024 that may be closed by this pull request
Remove duplicated links from help menu #6368
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@Tostti Tostti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove duplicated links from help menu
3 participants
@Tostti @yenienserrano @lucianogorza