Update usage of GET /groups/{group_id}/files/{file_name}/- json/xml

[JuanGarriuz]

Description

The following endpoints have been refactored:

GET /groups/{group_id}/files/{file_name}/json
GET /groups/{group_id}/files/{file_name}/xml

Therefore, a revision in the code to properly manage them has been necessary.

The change to the endpoints has been to remove the extension from the path and replace it with a raw variable, making it so that if the variable is set to true, it will return the response structured as an XML; if the parameter is not added, it will return the response as a JSON.

Within the front-end structure, no endpoint needs a JSON structure, so I have added the parameter raw=true as the default. This is reflected in the file plugins/main/public/controllers/management/components/management/groups/utils/groups-handler.js, in the function getFileContent.

Issues Resolved

Update usage of GET /groups/{group_id}/files/{file_name}/json and GET /groups/{group_id}/files/{file_name}/XML

Evidence

Evidence.mp4

Test

To generate a manager that works correctly, it will be necessary to use the master branch. For this, you can include this code in the dev.yml.

wazuh-manager-master:
    build:
      context: /PATH/TO/OLD_ENVIRONMENTS/images/wazuh_manager_filebeat_sources_cmake
      args:
        WAZUH_VERSION: 'master'
        FILEBEAT_VERSION: '7.10.2'
        FILEBEAT_WAZUH_TEMPLATE_URL: https://raw.githubusercontent.com/wazuh/wazuh/master/extensions/elasticsearch/7.x/wazuh-template.json
        FILEBEAT_WAZUH_MODULE_URL: https://packages.wazuh.com/4.x/filebeat/wazuh-filebeat-0.2.tar.gz
    image: wazuh-manager:master-7.10.2
    hostname: wazuh-manager-master-7102
    volumes:
      - '/PATH/TO/OLD_ENVIRONMENTS/config/filebeat/filebeat.odfe.yml:/etc/filebeat/filebeat.yml'
    ports:
      - '514:514'
      - '1514:1514'
      - '1515:1515'
      - '1516:1516'
      - '55000:55000'
    depends_on:
      - os1
    environment:
      NODE_IP: wazuh-manager-master
      NODE_NAME: manager-node
      NODE_TYPE: master
    networks:
      - os-dev

The files located in /wazuh_manager_filebeat_sources_cmake should be replaced with the following ones:

master-manager-enviroment.zip

• Check that all the edit and view options of endpoint groups function by displaying agent.conf

Check List

• All tests pass
  • yarn test:jest
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[Tostti]

Test

Video_2024-02-21_11-29-28.mp4

Test ✅
CR ✅

LGTM

[asteriscos]

CR: 🔴
We should delete commented code.
Missing changelog.

Test: 🟢

[asteriscos]

If this is not used I think we should remove it to avoid polluting the file.

[github-actions]

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	21.38%	( 176 / 823 )
Branches	19.45%	( 79 / 406 )
Functions	14.17%	( 36 / 254 )
Lines	21.57%	( 173 / 802 )

[github-actions]

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

[github-actions]

Main plugin code coverage (Jest) test	%	values
Statements	12.33%	( 4288 / 34757 )
Branches	8.08%	( 1855 / 22931 )
Functions	11.87%	( 988 / 8323 )
Lines	12.5%	( 4164 / 33290 )

[Tostti]

LGTM