Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix home view kpis styles #6408

Merged
merged 6 commits into from
Feb 15, 2024
Merged

Fix home view kpis styles #6408

merged 6 commits into from
Feb 15, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Feb 14, 2024 •
edited
Loading

Description

Fixes styling and redirection problem in home page KPIs

Issues Resolved

Evidence

Safari

image

Chrome

image

image

image

Test

  1. Check of the Home view KPIs must have the same font size and font-weight
  2. check that the KPIs Active Agents and Disconnected Agents redirect to the endpoint summary with the selected filter in the table

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Feb 14, 2024
@yenienserrano yenienserrano linked an issue Feb 14, 2024 that may be closed by this pull request
Fix Home view KPIs styles #6406
Closed
@yenienserrano yenienserrano marked this pull request as ready for review February 14, 2024 16:59
@yenienserrano yenienserrano requested a review from a team as a code owner February 14, 2024 16:59
@lucianogorza lucianogorza self-requested a review February 14, 2024 19:09
lucianogorza
lucianogorza previously approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

image
image
image
image

@JuanGarriuz
Copy link
Member

JuanGarriuz commented Feb 15, 2024 •
edited
Loading

Test 🟢

image
image
image

JuanGarriuz
JuanGarriuz previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.89% ( 186 / 890 )
Branches 17.91% ( 79 / 441 )
Functions 13.89% ( 36 / 259 )
Lines 21.1% ( 183 / 867 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.15% ( 4207 / 34598 )
Branches 8.21% ( 1907 / 23222 )
Functions 11.6% ( 956 / 8235 )
Lines 12.33% ( 4093 / 33192 )

Desvelao
Desvelao approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image
image
image

@Desvelao Desvelao merged commit 213d09e into 4.8.0 Feb 15, 2024
4 checks passed
@Desvelao Desvelao deleted the 6406-fix-home-view-kpis-styles branch February 15, 2024 11:43
@asteriscos asteriscos mentioned this pull request Feb 26, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@lucianogorza lucianogorza lucianogorza left review comments

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Home view KPIs styles
4 participants
@yenienserrano @JuanGarriuz @Desvelao @lucianogorza