Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove relative_dirname from CDB List #6458

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Remove relative_dirname from CDB List #6458

merged 2 commits into from
Feb 29, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Feb 29, 2024 •
edited
Loading

Description

This PR removes the relative_dirname when using CDB lists endpoints.

Issues Resolved

Closes #6455

Evidence

Peek 2024-02-29 12-34

Test

  • Go to Management -> CDB List
  • Click Import file button
  • Select a file to import
  • Refresh the table and check it was imported
  • Edit the imported file
  • Delete the imported file

Check List

  • All tests pass
    • yarn test:jest
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Feb 29, 2024
@asteriscos asteriscos linked an issue Feb 29, 2024 that may be closed by this pull request
relative_dirname parameter error when trying to upload CDB lists #6455
Closed
@asteriscos asteriscos mentioned this pull request Feb 29, 2024
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 11.73% ( 4048 / 34507 )
Branches 7.96% ( 1855 / 23300 )
Functions 11.26% ( 930 / 8257 )
Lines 11.91% ( 3937 / 33047 )

@Desvelao
Copy link
Member

🟢 Test

image
image
image

Desvelao
Desvelao approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yenienserrano
yenienserrano approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

image

image

image

@asteriscos asteriscos merged commit 568f1e2 into 4.7.3 Feb 29, 2024
2 checks passed
@asteriscos asteriscos deleted the fix/relative_dirname-parameter-error-6455 branch February 29, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

relative_dirname parameter error when trying to upload CDB lists
3 participants
@asteriscos @Desvelao @yenienserrano