Allow upgrade agent from actions column #6476

lucianogorza · 2024-03-05T16:10:20Z

Description

This PR's main objective is to provide Wazuh Dashboard users with the ability to easily update an outdated agent.
To achieve this, the Upgrade button has been added to the actions column of the agent's table.
Additionally, a badge has been included in the Version column to indicate if the agent is not up-to-date.
Finally, if there is any ongoing update, an alert is displayed showing the quantity in progress and the number of failures in the last 60 minutes, with the option to access the details of the failures.

Issues Resolved

#6253

Evidence

Test

Test with real manager and agents

Command to create outdated agent with docker:

docker run --name os-dev-2120-agent-$(date +%s) --network os-dev-2.12.0 --label com.docker.compose.project=os-dev-2120 --env WAZUH_AGENT_VERSION=4.6.0 -d ubuntu:20.04 bash -c '
  apt update -y
  apt install -y curl lsb-release
  curl -so \wazuh-agent-${WAZUH_AGENT_VERSION}.deb \
    https://packages.wazuh.com/4.x/apt/pool/main/w/wazuh-agent/wazuh-agent_${WAZUH_AGENT_VERSION}-1_amd64.deb \
    && WAZUH_MANAGER='wazuh.manager' WAZUH_AGENT_GROUP='default' dpkg -i ./wazuh-agent-${WAZUH_AGENT_VERSION}.deb

  /etc/init.d/wazuh-agent start
  tail -f /var/ossec/logs/ossec.log
'

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

General

Test	Chrome	Firefox	Safari
Version column: up to date agent must show only the version	⚫	⚫	⚫
Version column: outdated agent must show version and a badge	⚫	⚫	⚫
Up to date agent: In actions column click more actions. Upgrade action must be disabled	⚫	⚫	⚫
Outdated online agent: In actions column click more actions. Upgrade action must be enabled	⚫	⚫	⚫
Outdated offline agent: In actions column click more actions. Upgrade action must be disabled	⚫	⚫	⚫

Details

⚫ Version column: up to date agent must show only the version

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Version column: outdated agent must show version and a badge

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Up to date agent: In actions column click more actions. Upgrade action must be disabled

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Outdated online agent: In actions column click more actions. Upgrade action must be enabled

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Outdated offline agent: In actions column click more actions. Upgrade action must be disabled

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Upgrade agents

Test	Chrome	Firefox	Safari
Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)	⚫	⚫	⚫
Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown	⚫	⚫	⚫
Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details	⚫	⚫	⚫
On the upgrade tasks modal, check different filters	⚫	⚫	⚫

Details

⚫ Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ On the upgrade tasks modal, check different filters

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

yenienserrano · 2024-03-06T17:33:20Z

Maybe we could look for another alternative to show when an agent is out of date, for example a dot as in status and a tooltip, so that it stays in the same line.

yenienserrano · 2024-03-06T17:34:46Z

General

Test	Chrome	Firefox	Safari
Version column: up to date agent must show only the version	🟢	⚫	⚫
Version column: outdated agent must show version and a badge	🟢	⚫	⚫
Up to date agent: In actions column click more actions. Upgrade action must be disabled	🟢	⚫	⚫
Outdated online agent: In actions column click more actions. Upgrade action must be enabled	🟢	⚫	⚫
Outdated offline agent: In actions column click more actions. Upgrade action must be disabled	🟢	⚫	⚫

Details

🟢 Version column: up to date agent must show only the version

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Version column: outdated agent must show version and a badge

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Up to date agent: In actions column click more actions. Upgrade action must be disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Outdated online agent: In actions column click more actions. Upgrade action must be enabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Outdated offline agent: In actions column click more actions. Upgrade action must be disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

Upgrade agents

Test	Chrome	Firefox	Safari
Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)	🟢	⚫	⚫
Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown	🟢	⚫	⚫
Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details	🟢	⚫	⚫
On the upgrade tasks modal, check different filters	🟡	⚫	⚫

Details

🟢 Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟡 On the upgrade tasks modal, check different filters

Chrome - 🟡

I updated 1 agent and when I finished the message of 0 agents updating remained
and I can't see the history as when it gives an error

Firefox - ⚫

Safari - ⚫

yenienserrano · 2024-03-07T14:39:04Z

It is making several requests to check which ones are in progress, ready and failed, and when you open the modal to see the tasks, the requests multiply.

yenienserrano

LGTM

asteriscos · 2024-03-11T18:42:38Z

General

Test	Chrome	Firefox	Safari
Version column: up to date agent must show only the version	🟢	⚫	⚫
Version column: outdated agent must show version and a badge	🟢	⚫	⚫
Up to date agent: In actions column click more actions. Upgrade action must be disabled	🟢	⚫	⚫
Outdated online agent: In actions column click more actions. Upgrade action must be enabled	🟢	⚫	⚫
Outdated offline agent: In actions column click more actions. Upgrade action must be disabled	🟢	⚫	⚫

Details

🟢 Version column: up to date agent must show only the version

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Version column: outdated agent must show version and a badge

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Up to date agent: In actions column click more actions. Upgrade action must be disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Outdated online agent: In actions column click more actions. Upgrade action must be enabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Outdated offline agent: In actions column click more actions. Upgrade action must be disabled

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

Upgrade agents

Test	Chrome	Firefox	Safari
Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)	🟢	⚫	⚫
Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown	🟢	⚫	⚫
Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details	🟢	⚫	⚫
On the upgrade tasks modal, check different filters	🟢	⚫	⚫

Details

🟢 Go to an online and outdated agent, and click the upgrade action. Check the progress alert (API requests must be triggered every 3 seconds) and wait until the upgrade is finished (API requests must be stopped)

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to an online and outdated agent, and click the upgrade action. Refresh the entire page. The progress alert must be shown

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Go to an online and outdated agent, stop the Docker container, and click the upgrade action. Check the failed alert and open the modal to see the error details

Chrome - 🟢

Peek.2024-03-11.19-21.mp4

Firefox - ⚫

Safari - ⚫

🟢 On the upgrade tasks modal, check different filters

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

…ctions-column

github-actions · 2024-03-11T18:53:33Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-03-11T18:53:37Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	28.94%	( 286 / 988 )
Branches	26.22%	( 107 / 408 )
Functions	26.87%	( 86 / 320 )
Lines	28.68%	( 278 / 969 )

github-actions · 2024-03-11T18:58:00Z

Main plugin code coverage (Jest) test	%	values
Statements	11.83%	( 4093 / 34584 )
Branches	7.49%	( 1697 / 22644 )
Functions	10.5%	( 862 / 8206 )
Lines	12.02%	( 3986 / 33147 )

lucianogorza self-assigned this Mar 5, 2024

lucianogorza added 4 commits March 5, 2024 16:53

Add upgrade action

741907a

Add upgrade errors alert

0f945b7

Update CHANGELOG

a0034ae

Add unit tests

7a8d06d

lucianogorza force-pushed the enhancement/6253-allow-upgrade-agent-from-actions-column branch from 088b3f0 to 7a8d06d Compare March 5, 2024 19:53

lucianogorza linked an issue Mar 5, 2024 that may be closed by this pull request

Allow upgrade an agent from the actions table #6253

Closed

4 tasks

lucianogorza added 3 commits March 5, 2024 18:10

Fix filter

f91d414

Fix table filter suggestions

a4adbec

Fix search bar table suggestions

1cb2f13

Improve upgrade progress

48d7086

lucianogorza added 3 commits March 8, 2024 15:55

Improve API requests and modal refresh

1f60ce4

Improve imposter response for task status

620f4c5

Improve imposter response for task status

362f8f8

yenienserrano approved these changes Mar 11, 2024

View reviewed changes

asteriscos approved these changes Mar 11, 2024

View reviewed changes

Merge branch '4.9.0' into enhancement/6253-allow-upgrade-agent-from-a…

ce67475

…ctions-column

asteriscos merged commit 4a9fe77 into 4.9.0 Mar 11, 2024
1 check passed

asteriscos deleted the enhancement/6253-allow-upgrade-agent-from-actions-column branch March 11, 2024 18:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow upgrade agent from actions column #6476

Allow upgrade agent from actions column #6476

lucianogorza commented Mar 5, 2024 •

edited

Loading

yenienserrano commented Mar 6, 2024

yenienserrano commented Mar 6, 2024 •

edited

Loading

yenienserrano commented Mar 7, 2024

yenienserrano left a comment

asteriscos commented Mar 11, 2024 •

edited

Loading

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

Allow upgrade agent from actions column #6476

Allow upgrade agent from actions column #6476

Conversation

lucianogorza commented Mar 5, 2024 • edited Loading

Description

Issues Resolved

Evidence

Test

UI

General

Upgrade agents

Check List

yenienserrano commented Mar 6, 2024

yenienserrano commented Mar 6, 2024 • edited Loading

General

Upgrade agents

yenienserrano commented Mar 7, 2024

yenienserrano left a comment

Choose a reason for hiding this comment

asteriscos commented Mar 11, 2024 • edited Loading

General

Upgrade agents

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

github-actions bot commented Mar 11, 2024

lucianogorza commented Mar 5, 2024 •

edited

Loading

yenienserrano commented Mar 6, 2024 •

edited

Loading

asteriscos commented Mar 11, 2024 •

edited

Loading