Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent visualization and KPI to overview #6569

Merged
merged 14 commits into from
Apr 4, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Apr 2, 2024

Description

Added a dashboard in overview that shows an agent status and alerts

Issues Resolved

Add agent visualization and rule severity KPI to overview

Evidence

image

Test

Legend:
⚫: none
🟒: pass
🟑: warning
πŸ”΄: fail
βšͺ: not applicable

UI

Test Chrome Firefox Safari
Go to Overview and check dashboard renders the expected data ⚫ ⚫ ⚫
With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly ⚫ ⚫ ⚫
With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly ⚫ ⚫ ⚫
Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly ⚫ ⚫ ⚫

Details

⚫ Go to Overview and check dashboard render the correct data

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.8.0 April 2, 2024 12:12
@JuanGarriuz JuanGarriuz marked this pull request as ready for review April 2, 2024 12:12
@JuanGarriuz JuanGarriuz self-assigned this Apr 2, 2024
@JuanGarriuz JuanGarriuz linked an issue Apr 2, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@yenienserrano
Copy link
Member

yenienserrano commented Apr 4, 2024

Test Chrome Firefox Safari
Go to Overview and check dashboard renders the expected data ⚫ ⚫ 🟒
With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly ⚫ ⚫ 🟒
With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly ⚫ ⚫ 🟒
Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly ⚫ ⚫ 🟒

Details

🟒 Go to Overview and check dashboard render the correct data

Chrome - ⚫

Firefox - ⚫

Safari - 🟒

image
🟒 With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - ⚫

Firefox - ⚫

Safari - 🟒

image
🟒 With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - ⚫

Firefox - ⚫

Safari - 🟒

image
🟒 Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly

Chrome - ⚫

Firefox - ⚫

Safari - 🟒

image

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: βœ…
Test: βœ…

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4234 / 34726 )
Branches 8.28% ( 1928 / 23282 )
Functions 11.58% ( 959 / 8276 )
Lines 12.36% ( 4122 / 33329 )

@Tostti
Copy link
Member

Tostti commented Apr 4, 2024

Test Chrome Firefox Safari
Go to Overview and check dashboard renders the expected data 🟒 🟒 🟒
With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly 🟒 🟒 🟒
With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly 🟒 🟒 🟒
Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly 🟒 🟒 🟒

Details

🟒 Go to Overview and check dashboard render the correct data

Chrome - 🟒
image
image

Firefox - 🟒
image
image

Safari - 🟒

image
image

🟒 With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - 🟒
image

Firefox - 🟒
image

Safari - 🟒

image

🟒 With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly

Chrome - 🟒
image

Firefox - 🟒
image

Safari - 🟒
image

🟒 Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly

Chrome - 🟒
image

Firefox - 🟒
image

Safari - 🟒
image

Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test βœ…
CR βœ…

LGTM

@Tostti Tostti merged commit 680b9a3 into 4.8.0 Apr 4, 2024
4 checks passed
@Tostti Tostti deleted the feat/6550-add-agent-visualization-KPI-to-overview branch April 4, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add agent visualization and rule severity KPI to overview
5 participants