-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agent visualization and KPI to overview #6569
Merged
Tostti
merged 14 commits into
4.8.0
from
feat/6550-add-agent-visualization-KPI-to-overview
Apr 4, 2024
Merged
Add agent visualization and KPI to overview #6569
Tostti
merged 14 commits into
4.8.0
from
feat/6550-add-agent-visualization-KPI-to-overview
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Desvelao
reviewed
Apr 4, 2024
plugins/main/public/controllers/overview/components/last-alerts-stat/last-alerts-query.ts
Outdated
Show resolved
Hide resolved
Desvelao
reviewed
Apr 4, 2024
Desvelao
reviewed
Apr 4, 2024
plugins/main/public/controllers/overview/components/last-alerts-stat/last-alerts-stat.tsx
Outdated
Show resolved
Hide resolved
|
|
yenienserrano
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: β
Test: β
|
Details π’ Go to Overview and check dashboard render the correct dataSafari - π’ π’ With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctlySafari - π’ π’ With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly |
Tostti
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test β
CR β
LGTM
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a dashboard in overview that shows an agent status and alerts
Issues Resolved
Add agent visualization and rule severity KPI to overview
Evidence
Test
Legend:
β«: none
π’: pass
π‘: warning
π΄: fail
βͺ: not applicable
UI
Details
β« Go to Overview and check dashboard render the correct data
Chrome - β«
Firefox - β«
Safari - β«
β« With new Discover data explorer enabled, go to Overview and check dashboard links redirect to discover adding filters correctly
Chrome - β«
Firefox - β«
Safari - β«
β« With new Discover data explorer disabled, go to Overview and check dashboard links redirect to discover adding filters correctly
Chrome - β«
Firefox - β«
Safari - β«
β« Go to Overview and check agents visualization label links redirect to Endpoints summary adding filter correctly
Chrome - β«
Firefox - β«
Safari - β«
Check List
yarn test:jest