Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove monitoring AngularJS controllers #6579

Closed
wants to merge 5 commits into from
Closed

Remove monitoring AngularJS controllers #6579

wants to merge 5 commits into from

Conversation

yenienserrano
Copy link
Member

Description

This pull request removes the AngularJS controller for monitoring.

Issues Resolved

Evidence

[Provide screenshots or videos to prove this PR solves the issues]

Test

[Provide instructions to test this PR]

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano linked an issue Apr 8, 2024 that may be closed by this pull request
[Remove discover] Refactor angularJS monitoring.js #6575
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 31.12% ( 286 / 919 )
Branches 29.88% ( 107 / 358 )
Functions 28.1% ( 86 / 306 )
Lines 30.71% ( 278 / 905 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 8, 2024

Main plugin code coverage (Jest) test % values
Statements 10.81% ( 3769 / 34850 )
Branches 7.29% ( 1666 / 22833 )
Functions 10.47% ( 871 / 8317 )
Lines 10.96% ( 3663 / 33406 )

@yenienserrano yenienserrano self-assigned this Apr 8, 2024
@Desvelao
Copy link
Member

It is managed on #6532.

@Desvelao Desvelao closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remove discover] Refactor angularJS monitoring.js
2 participants
@yenienserrano @Desvelao