Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change getHistory for syncHistoryLocations #6591

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Apr 15, 2024

Description

Fixes a double rendering that was caused by redirects when logging in. (It also takes into account navigation between the different models, as the issue was added to solve a problem in navigation.)

Issues Resolved

Evidence

Grabacion.de.pantalla.2024-04-15.a.las.3.49.24.p.m.mov
image

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
The overview after login must be rendered once and must not have repeated requests to opensearch.
Navigate between dashboards with the events tab and without the events tab, navigation should work correctly.

Details

⚫ The overview after login must be rendered once and must not have repeated requests to opensearch.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Navigate between dashboards with the events tab and without the events tab, navigation should work correctly.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Apr 15, 2024
@yenienserrano yenienserrano linked an issue Apr 15, 2024 that may be closed by this pull request
@yenienserrano yenienserrano marked this pull request as ready for review April 15, 2024 19:33
@asteriscos asteriscos self-requested a review April 16, 2024 11:06
@asteriscos
Copy link
Member

asteriscos commented Apr 16, 2024

UI

Test Chrome Firefox Safari
The overview after login must be rendered once and must not have repeated requests to OpenSearch. 🟢 🟢
Navigate between dashboards with the events tab and without the events tab, navigation should work correctly. 🟢 🟢

Details

🟢 The overview after login must be rendered once and must not have repeated requests to opensearch.

Chrome - 🟢

Peek 2024-04-16 13-10

Firefox - 🟢

Peek 2024-04-16 13-12

Safari - ⚪

🟢 Navigate between dashboards with the events tab and without the events tab, navigation should work correctly.

Chrome - 🟢

Peek 2024-04-16 16-42

Firefox - 🟢

Peek 2024-04-16 16-45

Safari - ⚪

@JuanGarriuz JuanGarriuz self-requested a review April 16, 2024 12:08
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4234 / 34728 )
Branches 8.28% ( 1928 / 23282 )
Functions 11.58% ( 959 / 8277 )
Lines 12.36% ( 4122 / 33331 )

@JuanGarriuz
Copy link
Member

Test

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox Safari
The overview after login must be rendered once and must not have repeated requests to opensearch. 🟢
Navigate between dashboards with the events tab and without the events tab, navigation should work correctly. 🟢

Details

🟢 The overview after login must be rendered once and must not have repeated requests to opensearch.

Chrome - 🟢
image
image

Firefox - ⚫

Safari - ⚫

🟢 Navigate between dashboards with the events tab and without the events tab, navigation should work correctly.

Chrome - 🟢
image
image
image
image

Firefox - ⚫

Safari - ⚫

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!!

@asteriscos asteriscos merged commit bca15ab into 4.8.0 Apr 17, 2024
4 checks passed
@asteriscos asteriscos deleted the fix/6588-home-visualizations-load-twice branch April 17, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home visualizations load twice
3 participants