Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy discover references and methods #6646

Merged

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented May 7, 2024

Description

Removes code that referenced discover legacy

Issues Resolved

Evidence

image

Test

When navigating the dashboards, the error message with reference to discover:v2 should not be displayed.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this May 7, 2024
@yenienserrano yenienserrano linked an issue May 7, 2024 that may be closed by this pull request
@jbiset jbiset self-requested a review May 7, 2024 15:07
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Evidence

Evidence.webm

@lucianogorza lucianogorza self-requested a review May 7, 2024 15:25
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

Test 🟢

remove-discover-legacy.webm

@asteriscos asteriscos merged commit 49e00a9 into 4.9.0 May 7, 2024
1 check passed
@asteriscos asteriscos deleted the 6584-remove-legacy-discover-references-and-methods branch May 7, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove legacy discover references and methods
4 participants