Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide discover callout warning message #6690

Merged
merged 3 commits into from
May 22, 2024

Conversation

JuanGarriuz
Copy link
Member

Description

A localStorage.clear is modified so that it does not delete the state responsible for hiding the discover message.

Issues Resolved

Evidence

Before:

image

After:

image

Test

  • Go to Endpoint security > Configuration Assessment, pin and unpin an agent,
  • Go to OpenSearch Dashboards > Discover, and check that the discover callout warning message doesn't render.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.8.0 May 21, 2024 07:34
@JuanGarriuz JuanGarriuz marked this pull request as ready for review May 21, 2024 07:35
@JuanGarriuz JuanGarriuz linked an issue May 21, 2024 that may be closed by this pull request
@lucianogorza lucianogorza self-requested a review May 21, 2024 12:50
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

Test ✅

  • Go to Endpoint security > Configuration Assessment, pin and unpin an agent,

Initial status

image

Pin agent

image

Unpin agent

image

  • Go to OpenSearch Dashboards > Discover, and check that the discover callout warning message doesn't render.

image

lucianogorza
lucianogorza previously approved these changes May 21, 2024
@chantal-kelm chantal-kelm self-requested a review May 21, 2024 21:04
chantal-kelm
chantal-kelm previously approved these changes May 21, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image image image

@Desvelao Desvelao dismissed stale reviews from chantal-kelm and lucianogorza via 7eed5d0 May 22, 2024 06:43
Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.19% ( 4234 / 34727 )
Branches 8.28% ( 1928 / 23280 )
Functions 11.58% ( 959 / 8277 )
Lines 12.36% ( 4122 / 33330 )

@Desvelao Desvelao merged commit 684b1c8 into 4.8.0 May 22, 2024
4 checks passed
@Desvelao Desvelao deleted the feat/6683-discover-callout-warning-message branch May 22, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discover plugin legacy callout warning message
4 participants