Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change endpoints summary KPIs and index pattern and APIs selects font sizes #6702

Merged
merged 2 commits into from
May 23, 2024
Merged

Change endpoints summary KPIs and index pattern and APIs selects font sizes #6702

merged 2 commits into from
May 23, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented May 23, 2024 •
edited
Loading

Description

This pull request changes:

  • Removes bold font-weight from Endpoints summary KPIs Last enrolled agent and Most active agent
  • Changes index pattern and APIs selectors font sizes to 14.5 px
  • Changes the default console columns width of the Dev tools view
    • Left column 45%
    • Right column 55%

Issues Resolved

Closes #6699

Evidence

image

image

Test

  • Check the font-weight from Endpoints summary KPIs Last enrolled agent and Most active agent is normal
  • Check the index pattern and APIs selectors font sizes are 14.5 px
  • Check the default console columns width of the Dev tools view are:
    • Left column 45%
    • Right column 55%

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this May 23, 2024
@asteriscos asteriscos linked an issue May 23, 2024 that may be closed by this pull request
Change font sizes and dev tools column size #6699
Closed
3 tasks
@yenienserrano yenienserrano self-requested a review May 23, 2024 12:50
@yenienserrano
Copy link
Member

Test

  • Check the font-weight from Endpoints summary KPIs Last enrolled agent and Most active agent is normal
Details image
  • Check the index pattern and APIs selectors font sizes are 14.5 px
Details

image

  • Check the default console columns width of the Dev tools view are:
    • Left column 45%
    • Right column 55%
Details image image

yenienserrano
yenienserrano previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucianogorza
Copy link
Contributor

lucianogorza commented May 23, 2024 •
edited
Loading

Test

  • Check the font-weight from Endpoints summary KPIs Last enrolled agent and Most active agent is normal
Details

image
image

  • Check the index pattern and APIs selectors font sizes are 14.5 px
Details

image

  • Check the default console columns width of the Dev tools view are:
    • Left column 45%
    • Right column 55%
Details

image
image

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 20.94% ( 187 / 893 )
Branches 17.91% ( 79 / 441 )
Functions 13.79% ( 36 / 261 )
Lines 21.14% ( 184 / 870 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.78% ( 172 / 224 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.78% ( 172 / 224 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 12.3% ( 4278 / 34779 )
Branches 8.31% ( 1938 / 23294 )
Functions 11.63% ( 964 / 8284 )
Lines 12.48% ( 4168 / 33383 )

lucianogorza
lucianogorza approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@lucianogorza lucianogorza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit 489c10b into 4.8.0 May 23, 2024
4 checks passed
@asteriscos asteriscos deleted the change/endpoints-kpi-and-top-selects-font-sizes-6699 branch May 23, 2024 15:34
@asteriscos asteriscos mentioned this pull request May 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@lucianogorza lucianogorza lucianogorza approved these changes

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change font sizes and dev tools column size
3 participants
@asteriscos @yenienserrano @lucianogorza