Fix minor styles #6708
Merged
Fix minor styles #6708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
TestLegend: UI
Details 🟢 Go to Threat Hunting -> Dashboard. Check the bottom table spacesChrome - ⚫ Firefox - ⚫ Safari - 🟢 
🟢 Go to Threat Hunting -> Events. The layout should have the same spaces as the Dashboard tab.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 
🟢 Go to Vulnerability Detection -> Inventory. The layout should have the same spaces as the Dashboard tab.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 
🟢 Go to Mitre Att&ct -> Intelligence. The layout should have the same spaces as the Dashboard tab.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 
🟢 Go to Mitre Att&ct -> Framework. The layout should have the same spaces as the Dashboard tab.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 
🟢 Go to PCI DSS -> Controls. The layout should have the same spaces as the Dashboard tab.Chrome - ⚫ Firefox - ⚫ Safari - 🟢 
|
lucianogorza
force-pushed
the
fix/6692-minor-style-issues
branch
from
e66f599
to
78dd6e7
Compare
chantal-kelm
approved these changes
May 29, 2024
There was a problem hiding this comment.
CR: ✅
Test: ✅
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Go to Threat Hunting -> Dashboard. Check the bottom table spaces | 🟢 | ⚫ | ⚫ |
| Go to Threat Hunting -> Events. The layout should have the same spaces as the Dashboard tab. | 🟢 | ⚫ | ⚫ |
| Go to Vulnerability Detection -> Inventory. The layout should have the same spaces as the Dashboard tab. | 🟢 | ⚫ | ⚫ |
| Go to Mitre Att&ct -> Intelligence. The layout should have the same spaces as the Dashboard tab. | 🟢 | ⚫ | ⚫ |
| Go to Mitre Att&ct -> Framework. The layout should have the same spaces as the Dashboard tab. | 🟢 | ⚫ | ⚫ |
| Go to PCI DSS -> Controls. The layout should have the same spaces as the Dashboard tab. | 🟢 | ⚫ | ⚫ |
Details
🟢 Go to Threat Hunting -> Dashboard. Check the bottom table spaces
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
🟢 Go to Threat Hunting -> Events. The layout should have the same spaces as the Dashboard tab.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to Vulnerability Detection -> Inventory. The layout should have the same spaces as the Dashboard tab.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to Mitre Att&ct -> Intelligence. The layout should have the same spaces as the Dashboard tab.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to Mitre Att&ct -> Framework. The layout should have the same spaces as the Dashboard tab.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to PCI DSS -> Controls. The layout should have the same spaces as the Dashboard tab.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR aims to standardize the spacing and margins between different components in the Events, Inventory, and Controls tabs across the various modules.
Issues Resolved
#6692
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to Threat Hunting -> Dashboard. Check the bottom table spaces
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Threat Hunting -> Events. The layout should have the same spaces as the Dashboard tab.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Vulnerability Detection -> Inventory. The layout should have the same spaces as the Dashboard tab.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Mitre Att&ct -> Intelligence. The layout should have the same spaces as the Dashboard tab.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Mitre Att&ct -> Framework. The layout should have the same spaces as the Dashboard tab.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to PCI DSS -> Controls. The layout should have the same spaces as the Dashboard tab.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest