Remove total outdated agents statistic from Endpoint Summary #6737

lucianogorza · 2024-06-03T15:20:37Z

Description

This PR addresses the following changes:

Removed outdated agents' statistic from the Endpoints Summary page:
- The outdated agents' statistic has been removed to streamline the information displayed on the Endpoints Summary page.
Moved state management to table component:
- The state management for the total number of outdated agents has been shifted from the Endpoints Summary page to the table component. This ensures that the table component independently manages and reflects the accurate count of outdated agents.

Issues Resolved

#6736

Evidence

Test

Important

Test with a real 4.9.0 manager and at least one outdated agent.

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test	Chrome	Firefox	Safari
Verified that the Endpoints Summary page no longer displays the outdated agents' statistic.	⚫	⚫	⚫
If there are outdated agents, then the agents table must display the total.	⚫	⚫	⚫
If there are outdated agents, turning on the switch should make the table display only those agents.	⚫	⚫	⚫
If there are no outdated agents, then the agents table should disable the switch.	⚫	⚫	⚫
Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.	⚫	⚫	⚫
Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".	⚫	⚫	⚫

Details

⚫ Verified that the Endpoints Summary page no longer displays the outdated agents' statistic.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ If there are outdated agents, then the agents table must display the total.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ If there are outdated agents, turning on the switch should make the table display only those agents.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ If there are no outdated agents, then the agents table should disable the switch.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

⚫ Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".

Chrome - ⚫

Firefox - ⚫

Safari - ⚫

Check List

All tests pass
- yarn test:jest
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

JuanGarriuz · 2024-06-04T08:39:26Z

Test

Important

Test with a real 4.9.0 manager and at least one outdated agent.

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

Test	Chrome	Firefox	Safari
Verified that the Endpoints Summary page no longer displays the outdated agents' statistic.	🟢	⚫	⚫
If there are outdated agents, then the agents table must display the total.	🟢	⚫	⚫
If there are outdated agents, turning on the switch should make the table display only those agents.	🟢	⚫	⚫
If there are no outdated agents, then the agents table should disable the switch.	🟢	⚫	⚫
Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.	🟢	⚫	⚫
Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".	🟢	⚫	⚫

🟢 Verified that the Endpoints Summary page no longer displays the outdated agents' statistic.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 If there are outdated agents, then the agents table must display the total.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 If there are outdated agents, turning on the switch should make the table display only those agents.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 If there are no outdated agents, then the agents table should disable the switch.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

🟢 Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".

Chrome - 🟢

Firefox - ⚫

Safari - ⚫

JuanGarriuz

LGTM!!!

asteriscos

Test: 🔴

The total amount of outdated agents doesn't consider the filters applied to the table, such as a particular group selected.
To make the outdated agents value consistent with the table results, it should include all pre-applied filters to the query.

lucianogorza · 2024-06-04T17:49:38Z

Test: 🔴

The total amount of outdated agents doesn't consider the filters applied to the table, such as a particular group selected. To make the outdated agents value consistent with the table results, it should include all pre-applied filters to the query.

Fixed in this commit

github-actions · 2024-06-04T17:50:13Z

Wazuh Core plugin code coverage (Jest) test	%	values
Statements	45.96%	( 399 / 868 )
Branches	41.97%	( 157 / 374 )
Functions	44.01%	( 136 / 309 )
Lines	46.16%	( 397 / 860 )

github-actions · 2024-06-04T17:50:28Z

Wazuh Check Updates plugin code coverage (Jest) test	%	values
Statements	76.44%	( 172 / 225 )
Branches	58.65%	( 61 / 104 )
Functions	61.7%	( 29 / 47 )
Lines	76.44%	( 172 / 225 )

github-actions · 2024-06-04T17:55:09Z

Main plugin code coverage (Jest) test	%	values
Statements	11.33%	( 3879 / 34234 )
Branches	7.53%	( 1698 / 22536 )
Functions	10.62%	( 890 / 8376 )
Lines	11.49%	( 3776 / 32862 )

asteriscos · 2024-06-05T14:34:40Z

Test	Firefox
Verified that the Endpoints Summary page no longer displays the outdated agents' statistic.	🟢
If there are outdated agents, then the agents table must display the total.	🟢
If there are outdated agents, turning on the switch should make the table display only those agents.	🟢
If there are no outdated agents, then the agents table should disable the switch.	🟢
Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.	🟢
Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".	🟢

Details

🟢 Verified that the Endpoints Summary page no longer displays the outdated agents' statistics.

Firefox - 🟢

🟢 If there are outdated agents, then the agent's table must display the total.

Firefox - 🟢

🟢 If there are outdated agents, turning on the switch should make the table display only those agents.

Firefox - 🟢

🟢 If there are no outdated agents, then the agents table should disable the switch.

Firefox - 🟢

🟢 Verified that the Agent Welcome page (with data) adapts the components correctly por 850px screen width.

Firefox - 🟢

🟢 Check Endpoint Summary statistic titles: Must be "Top 5 OS" and "Top 5 groups".

Firefox - 🟢

asteriscos

CR: 🟢
Test: 🟢

Remove total outdated agents statistic from Endpoint Summary

e0a6f86

lucianogorza self-assigned this Jun 3, 2024

lucianogorza linked an issue Jun 3, 2024 that may be closed by this pull request

Remove total outdated agents statistic from Endpoint Summary #6736

Closed

7 tasks

lucianogorza added 2 commits June 3, 2024 12:53

Change upgrade tasks panel color

3a215ba

Update CHANGELOG

bb35284

lucianogorza marked this pull request as ready for review June 3, 2024 16:03

lucianogorza marked this pull request as draft June 3, 2024 17:42

Improve Agent Welcome layout

ac09de8

lucianogorza marked this pull request as ready for review June 3, 2024 20:51

JuanGarriuz self-requested a review June 4, 2024 07:46

JuanGarriuz previously approved these changes Jun 4, 2024

View reviewed changes

Update Endpoint Summary statistic titles

43ecd48

lucianogorza dismissed JuanGarriuz’s stale review via 43ecd48 June 4, 2024 12:54

asteriscos self-requested a review June 4, 2024 13:50

asteriscos requested changes Jun 4, 2024

View reviewed changes

lucianogorza added 2 commits June 4, 2024 13:12

Fix vulnerabilities data source

e7f6084

Synchronize total outdated agents and the rest filters

6b5b899

JuanGarriuz approved these changes Jun 5, 2024

View reviewed changes

asteriscos approved these changes Jun 5, 2024

View reviewed changes

asteriscos merged commit 1c73ab3 into 4.9.0 Jun 5, 2024
4 checks passed

asteriscos deleted the enhancenment/6736-remove-total-outdated-agents-statistic-from-endpoint-summary branch June 5, 2024 15:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove total outdated agents statistic from Endpoint Summary #6737

Remove total outdated agents statistic from Endpoint Summary #6737

lucianogorza commented Jun 3, 2024 •

edited

Loading

JuanGarriuz commented Jun 4, 2024 •

edited

Loading

JuanGarriuz left a comment

asteriscos left a comment

lucianogorza commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

asteriscos commented Jun 5, 2024

asteriscos left a comment

Remove total outdated agents statistic from Endpoint Summary #6737

Remove total outdated agents statistic from Endpoint Summary #6737

Conversation

lucianogorza commented Jun 3, 2024 • edited Loading

Description

Issues Resolved

Evidence

Test

Check List

JuanGarriuz commented Jun 4, 2024 • edited Loading

Test

JuanGarriuz left a comment

Choose a reason for hiding this comment

asteriscos left a comment

Choose a reason for hiding this comment

lucianogorza commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

github-actions bot commented Jun 4, 2024

asteriscos commented Jun 5, 2024

asteriscos left a comment

Choose a reason for hiding this comment

lucianogorza commented Jun 3, 2024 •

edited

Loading

JuanGarriuz commented Jun 4, 2024 •

edited

Loading