Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styles in small height viewports #6747

Merged
merged 15 commits into from
Jun 10, 2024

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Jun 5, 2024

Description

  • Fix the discover table small viewport and remove duplicated code in CSS classes.
  • Fix invalid date in the grid in Firefox and Safari.
  • Fix the data grid full screen height and scroll.
  • Set the minimum width for wazuh discover flyout field headers.
  • Fix date format with pinned agent in Mitre att&ck -> Framework flyout

Issues Resolved

Evidence

Grabacion.2024-06-05.130411.mp4

image

image

Test

Data grid

  • Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view)
  • Check that the full screen in the inventory tab table works as expected.
  • Check Threat intelligence > Threat Hunting > dashboard view render correctly

Controls flyout details

  • In Security operations > TSC > Controls checks Flyout > Rule > Details don't shows data in JSON format

Fix date format with pinned agent in Mitre att&ck -> Framework flyout

  • With pinned agent in Mitre att&ck -> Framework flyout, check the date is formated

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz changed the base branch from master to 4.9.0 June 5, 2024 11:30
@JuanGarriuz JuanGarriuz linked an issue Jun 6, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz marked this pull request as ready for review June 6, 2024 07:12
@yenienserrano
Copy link
Member

Test

  • 🟡 Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view)
Details

I don't know if I understood the issue correctly but maybe you also want to remove the scroll inside the table so that the page only has the scroll.

Screen.Recording.2024-06-06.at.3.56.41.PM.mov
  • 🔴 Check full screen in the inventory tab table works as expected.
Details

🟢 Events

image

🔴 Threat Hunting / dashboard

Table options are not visible

image

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: In Progress - Comment added

Test UI 🔴

Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view) 🔴

There is a difference between table scrolling in Chrome and Firefox. In Chrome the table does not have a scrollbar and grows by the size of the table. On the other hand, in Firefox the table does not grow and a scroolbar appears for the body of the table.

  • Chrome
Evidence_1_Chrome.webm
  • Firefox
Evidence_1_Firefox.webm

Check full screen in the inventory tab table works as expected. 🟢

  • Chrome
Evidence_2_Chrome.webm
  • Firefox
Evidence_2_Firefox.webm

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Main plugin code coverage (Jest) test % values
Statements 11.38% ( 3897 / 34235 )
Branches 7.63% ( 1721 / 22550 )
Functions 10.67% ( 894 / 8375 )
Lines 11.54% ( 3794 / 32867 )

@yenienserrano
Copy link
Member

yenienserrano commented Jun 7, 2024

Test

Data grid

  • Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view)
  • Check that the full screen in the inventory tab table works as expected.
  • Check Threat intelligence > Threat Hunting > dashboard view render correctly
Details
Screen.Recording.2024-06-07.at.9.25.25.PM.mov

Controls flyout details

  • In Security operations > TSC > Controls checks Flyout > Rule > Details don't shows data in JSON format
Details image

Fix date format with pinned agent in Mitre att&ck -> Framework flyout

  • With pinned agent in Mitre att&ck -> Framework flyout, check the date is formated
Details image

Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢

Test UI 🟢

Check that inventory tabs around the app are rendered correctly (The tab selector doesn't must stay on the top of view) 🟢

  • Chrome
Evidence_1_Chrome_ok.webm
  • Firefox
Evidence_1_Firefox_ok.webm

Check full screen in the inventory tab table works as expected. 🟢

  • Chrome
Evidence_2_Chrome.webm
  • Firefox
Evidence_2_Firefox.webm

Check Threat intelligence > Threat Hunting > dashboard view render correctly 🟢

  • Chrome
Evidence_3_Chrome_ok.webm
  • Firefox
Evidence_3_Firefox_ok.webm

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asteriscos asteriscos merged commit 45bdc7b into 4.9.0 Jun 10, 2024
4 checks passed
@asteriscos asteriscos deleted the feat/6740-fix-styles-in-small-height-viewports branch June 10, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New discover table gets hidden in small height viewports
6 participants