Rendering changes to embedded dashboards #6752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenienserrano
changed the title
CR 🟢Test 🟢🟢 Amazon web servicesaws.webm🟢 Dockerdocker.webm🟢 FIMfim.webm🟢 GDPRgdpr.webm🟢 Githubgithub.webm🟢 Google cloudgc.webm🟢 HIPAAhipaa.webm🟢 Malware detectionmalware-detection.webm🟢 Mitre Attackmitre.webm🟢 NISTnist.webm🟢 Office 365office365.webm🟢 PCIPCI.webm🟢 Threat huntingth.webm🟢 TSCtsc.webm🟢 Virus totalvirus-total.webm🟢 Vulnerabilitiesvd.webm |
CR 🟢Test 🟢🟢 Amazon web services
🟢 Docker
🟢 FIM
🟢 GDPR
🟢 Github
🟢 Google cloud
🟢 HIPAA
🟢 Malware detection
🟢 Mitre Attack
🟢 NIST
🟢 Office 365
🟢 PCI
🟢 Threat hunting
🟢 TSC
🟢 Virus total
🟢 Vulnerabilities
|
lucianogorza
previously approved these changes
Jun 10, 2024
lucianogorza
previously approved these changes
Jun 10, 2024
|
|
|
lucianogorza
approved these changes
Jun 10, 2024
asteriscos
approved these changes
Jun 10, 2024
asteriscos
deleted the
bug/6744-quick-change-between-dashboard-tabs-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes the way embeddables are rendered. Before it was a conditional rendering which made the error more visible and now it is always rendered and the conditional keeps the dashboards hidden or not by css.
Issues Resolved
Evidence
Screen.Recording.2024-06-07.at.8.36.18.PM.mov
Test
Check that the visualisations still work when changing tabs quickly.
Review the modules:
Check List
yarn test:jest