Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The selected filter is not applied when redirecting to the events tab in the file integrity monitoring module #6847

Merged
merged 5 commits into from
Jul 24, 2024
Merged

The selected filter is not applied when redirecting to the events tab in the file integrity monitoring module #6847

merged 5 commits into from
Jul 24, 2024

Conversation

chantal-kelm
Copy link
Member

Description

This PR fix the issue the selected filter is not applied when redirecting to the events tab in the file integrity monitoring module.

Issues Resolved

#6846

Evidence

Grabacion.de.pantalla.2024-07-18.a.la.s.2.26.49.p.m.mov

Test

  • Go to the File integrity monitoring module in the inventory tab, we select a value from the table, the flyout is displayed and we click on the recent events icon to go to the events tab, when redirecting to events the filter selected should be applied.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm
fix the selected filter is not applied when redirecting to the events…
0212204 
… tab in the file integrity monitoring module
@chantal-kelm chantal-kelm self-assigned this Jul 18, 2024
@chantal-kelm chantal-kelm linked an issue Jul 18, 2024 that may be closed by this pull request
The selected filter is not applied when redirecting to the events tab in the file integrity monitoring module #6846
Closed
@yenienserrano
Copy link
Member

Test: 🟡

When navigating back to inventory, the flyout reopens again, is that expected?

Screen.Recording.2024-07-19.at.12.09.36.PM.mov

yenienserrano
yenienserrano reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog is missing

@chantal-kelm
Merge branch '4.9.0' into bug/6846-the-selected-filter-is-not-applied…
5922277 
…-when-redirecting-to-the-events-tab-in-the-file-integrity-monitoring-module
@jbiset
Copy link
Member

jbiset commented Jul 19, 2024

Test: 🟡

When navigating back to inventory, the flyout reopens again, is that expected?

Screen.Recording.2024-07-19.at.12.09.36.PM.mov

It was tested in 4.7.2 and 4.8.1 and the behavior is the same. Therefore, it is assumed that it is expected.

@jbiset jbiset self-requested a review July 19, 2024 16:18
jbiset
jbiset reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: 🟢 (Add the CHANGELOG)

Test UI: 🟢

Evidence

Evidence.webm

yenienserrano
yenienserrano previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbiset
jbiset previously approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chantal-kelm chantal-kelm dismissed stale reviews from jbiset and yenienserrano via 4eeb8c2 July 22, 2024 17:33
jbiset
jbiset approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@jbiset jbiset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chantal-kelm
Merge branch '4.9.0' into bug/6846-the-selected-filter-is-not-applied…
24a0d6b 
…-when-redirecting-to-the-events-tab-in-the-file-integrity-monitoring-module
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.64% ( 3989 / 29237 )
Branches 9.1% ( 1744 / 19153 )
Functions 13.35% ( 943 / 7061 )
Lines 13.82% ( 3886 / 28099 )

@lucianogorza lucianogorza merged commit f868722 into 4.9.0 Jul 24, 2024
5 checks passed
@lucianogorza lucianogorza deleted the bug/6846-the-selected-filter-is-not-applied-when-redirecting-to-the-events-tab-in-the-file-integrity-monitoring-module branch July 24, 2024 16:09
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
@asteriscos asteriscos mentioned this pull request Aug 21, 2024
Closed
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbiset jbiset jbiset approved these changes

@yenienserrano yenienserrano yenienserrano approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The selected filter is not applied when redirecting to the events tab in the file integrity monitoring module
4 participants
@chantal-kelm @yenienserrano @jbiset @lucianogorza