Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes report generation when have a pinned agent #6873

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Fixes report generation when have a pinned agent #6873

merged 5 commits into from
Jul 29, 2024

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Jul 25, 2024 •
edited by Desvelao
Loading

Description

Fixes the report creation when the agent is pinned, it was failing because the filter was always phrases and when it is 1 agent it has to be phrase.

It fixes a missing filter related to cluster/manager when generating the agent inventory report on Inventory data.

Issues Resolved

Evidence

image
image
image
image

Test

  • Navigate to the different views that can be created with and without a pinned agent report
  • Test that the report is created correctly

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano self-assigned this Jul 25, 2024
@yenienserrano yenienserrano linked an issue Jul 25, 2024 that may be closed by this pull request
Error generating report on Agent Inventory Data section #6872
Closed
JuanGarriuz
JuanGarriuz approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

image
image
image
image

CR 🟢

LGTM!!!

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.63% ( 3990 / 29257 )
Branches 9.11% ( 1746 / 19165 )
Functions 13.34% ( 943 / 7065 )
Lines 13.82% ( 3887 / 28121 )

@chantal-kelm chantal-kelm self-requested a review July 29, 2024 16:12
chantal-kelm
chantal-kelm approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Grabacion.de.pantalla.2024-07-29.a.la.s.1.21.54.p.m.mov

@asteriscos asteriscos changed the title Fixes report generation when have a pined agent Fixes report generation when have a pinned agent Jul 29, 2024
@lucianogorza lucianogorza merged commit b4df0b3 into 4.9.0 Jul 29, 2024
5 checks passed
@lucianogorza lucianogorza deleted the bug/6872-error-generating-report-on-agent-inventory-data-section branch July 29, 2024 16:43
@asteriscos asteriscos mentioned this pull request Aug 5, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@yenienserrano yenienserrano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error generating report on Agent Inventory Data section
5 participants
@yenienserrano @chantal-kelm @JuanGarriuz @lucianogorza @Desvelao