Display rule details flyout based on URL #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o bug/6885-display-rule-details-based-on-URL
…o bug/6885-display-rule-details-based-on-URL
|
|
|
asteriscos
approved these changes
Jul 31, 2024
JuanGarriuz
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
| Test | Chrome | Firefox | Safari |
|---|---|---|---|
| Go to some link that sets the redirectRule query parameter and click on it. For example, on Threat Hunting > Events on the rule.id field value. | 🟢 | ⚫ | ⚫ |
| Go to Rules and click on a table row, this should open the rule details flyout and set the redirectRule URL query parameter | 🟢 | ⚫ | ⚫ |
| Open a rule details flyout and close it, the redirectRule URL query parameter should be removed | 🟢 | ⚫ | ⚫ |
Details
🟢 Go to some link that sets the redirectRule query parameter and click on it. For example, on Threat Hunting > Events on the rule.id field value.
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Go to Rules and click on a table row, this should open the rule details flyout and set the redirectRule URL query parameter
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
🟢 Open a rule details flyout and close it, the redirectRule URL query parameter should be removed
Chrome - 🟢
Firefox - ⚫
Safari - ⚫
CR 🟢
LGTM!!!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the display to rule details flyout to be based on URL.
Issues Resolved
#6885
Evidence
redirectRuleURL query parameter when the rule details flyout is openredirectRuleURL query parameter is not present when the rule detail flyout is not openTest
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to some link that sets the redirectRule query parameter and click on it. For example, on Threat Hunting > Events on the rule.id field value.
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Rules and click on a table row, this should open the rule details flyout and set the redirectRule URL query parameter
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Open a rule details flyout and close it, the redirectRule URL query parameter should be removed
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest