Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endpoints summary agent action buttons navigation #6893

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

asteriscos
Copy link
Member

Description

Hi team,
this pull request fixes the navigation method of the endpoint summary table action buttons, so the buttons use an in-module navigation method.

Issues Resolved

Closes #6892

Evidence

Peek 2024-08-01 11-51

Test

  1. Go to Endpoints summary
  2. Click on the 👁️ button of an agent row to navigate to the agent details. Then go back in the browser history.
  3. Click on the ... button of an agent row to expand the actions, then click on View agent details to test the navigation.
  4. Click on the ... button of an agent row to expand the actions, then click on Agent configuration to navigate to the agent configuration.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@asteriscos asteriscos self-assigned this Aug 1, 2024
@asteriscos asteriscos linked an issue Aug 1, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Main plugin code coverage (Jest) test % values
Statements 13.67% ( 4003 / 29267 )
Branches 9.12% ( 1747 / 19143 )
Functions 13.36% ( 945 / 7070 )
Lines 13.86% ( 3900 / 28133 )

@chantal-kelm chantal-kelm self-requested a review August 1, 2024 10:15
@JuanGarriuz JuanGarriuz self-requested a review August 1, 2024 10:18
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabacion.de.pantalla.2024-08-01.a.la.s.7.14.46.a.m.mov

Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢

  1. Go to Endpoints summary
  2. Click on the 👁️ button of an agent row to navigate to the agent details. Then go back in the browser history.
  3. Click on the ... button of an agent row to expand the actions, then click on View agent details to test the navigation.
  4. Click on the ... button of an agent row to expand the actions, then click on Agent configuration to navigate to the agent configuration.
Grabacion.2024-06-11.123352.mp4

CR 🟢

LGTM!!!

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screen.Recording.2024-08-01.at.12.29.31.PM.mov

@asteriscos asteriscos merged commit 422ff84 into 4.9.0 Aug 1, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/6892-fix-agent-action-buttons-navigation branch August 1, 2024 10:33
@Machi3mfl
Copy link
Member

CR: ✅
Test: ✅

Screen.Recording.2024-08-01.at.07.33.46.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View agent details buttons don't work
5 participants