Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default sorting and columns in all data grid tables #6912

Merged
merged 12 commits into from
Aug 19, 2024
Merged

Add default sorting and columns in all data grid tables #6912

merged 12 commits into from
Aug 19, 2024

Conversation

Machi3mfl
Copy link
Member

@Machi3mfl Machi3mfl commented Aug 16, 2024 •
edited
Loading

Description

This PR, adds the default sorting in the events table and vulnerability detection section

Closes

Tests

  • Check timestamp default sorting in all data grid table
Screen.Recording.2024-08-16.at.13.09.50.mov
Screen.Recording.2024-08-16.at.13.11.08.mov
Screen.Recording.2024-08-16.at.13.12.13.mov
  • Check timestamp default sorting and package.version column in vulnerability detector section
Screenshot 2024-08-16 at 13 15 14

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@Machi3mfl Machi3mfl changed the title Add default sorting and columns Add default sorting and columns in all data grid tables Aug 16, 2024
@chantal-kelm chantal-kelm self-requested a review August 16, 2024 17:35
chantal-kelm
chantal-kelm previously approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Check timestamp default sorting in all data grid table
Captura de pantalla 2024-08-16 a la(s) 2 39 08 p  m Captura de pantalla 2024-08-16 a la(s) 2 38 09 p  m Captura de pantalla 2024-08-16 a la(s) 2 38 17 p  m Captura de pantalla 2024-08-16 a la(s) 2 39 58 p  m Captura de pantalla 2024-08-16 a la(s) 2 39 47 p  m Captura de pantalla 2024-08-16 a la(s) 2 39 30 p  m Captura de pantalla 2024-08-16 a la(s) 2 39 18 p  m Captura de pantalla 2024-08-16 a la(s) 2 38 46 p  m Captura de pantalla 2024-08-16 a la(s) 2 38 38 p  m Captura de pantalla 2024-08-16 a la(s) 2 38 25 p  m Captura de pantalla 2024-08-16 a la(s) 2 40 09 p  m Captura de pantalla 2024-08-16 a la(s) 2 40 20 p  m Captura de pantalla 2024-08-16 a la(s) 2 40 31 p  m Captura de pantalla 2024-08-16 a la(s) 2 40 44 p  m Captura de pantalla 2024-08-16 a la(s) 2 40 55 p  m Captura de pantalla 2024-08-16 a la(s) 2 41 04 p  m Captura de pantalla 2024-08-16 a la(s) 2 41 42 p  m
  • Check timestamp default sorting and package.version column in vulnerability detector section
Captura de pantalla 2024-08-16 a la(s) 2 43 52 p  m

@Desvelao
Copy link
Member

Add the changelog entry.

@asteriscos asteriscos linked an issue Aug 19, 2024 that may be closed by this pull request
Vulnerability Detector - Add version field and order alerts wazuh/wazuh-dashboard#268
Closed
@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.96% ( 399 / 868 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.16% ( 397 / 860 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.57% ( 4008 / 29519 )
Branches 9.1% ( 1759 / 19325 )
Functions 13.27% ( 944 / 7111 )
Lines 13.75% ( 3906 / 28403 )

@chantal-kelm chantal-kelm self-requested a review August 19, 2024 12:52
@asteriscos asteriscos merged commit b52529b into 4.9.0 Aug 19, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/268-add-default-sorting-and-columns branch August 19, 2024 14:30
This was referenced Aug 21, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Desvelao Desvelao Desvelao left review comments

@chantal-kelm chantal-kelm chantal-kelm approved these changes

Assignees

@Machi3mfl Machi3mfl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vulnerability Detector - Add version field and order alerts
4 participants
@Machi3mfl @Desvelao @chantal-kelm @asteriscos