Removed agent RBAC filters from dashboard queries #6945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix 4.9.0 changelog * Remove 6519 reverted pull request
* Bump 4.9.0 revision 06 RC1 * Format
Machi3mfl
changed the title
JuanGarriuz
previously approved these changes
Aug 30, 2024
jbiset
reviewed
Aug 30, 2024
There was a problem hiding this comment.
CR: 🟡
There are quite a few changes in the CHANGELOG that are not known to be correct because nothing is mentioned in the PR about them.
The change in this PR is not visible in the CHANGELOG
Test UI: 🟢
Remove allowed agents filters on data source 🟢
Remove allowed agents state from redux appStateReducers 🟢
Remove allowed agents filters on reporting (wz-reporting) 🟢
evidence_report.webm
Machi3mfl
changed the title
Machi3mfl
changed the title
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove all use of RBAC filters such as
agents allowed.Closes #6943
Remove allowed agents filters on data source
Before
After
Remove allowed agents state from redux appStateReducers
Note
This method is placed on WzAuthorization and is used on every login.
This adds the allowed agent's list on the app state
Before
Screen.Recording.2024-08-26.at.12.30.00.mov
After
Remove allowed agents filters on reporting (wz-reporting)
Note
extendedInformation
Before
After
Note
Test all module reports
Screen.Recording.2024-08-27.at.15.54.57.mov
Check List
yarn test:jest