Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to filter by field in the events table rows #6991

Merged
merged 26 commits into from
Sep 17, 2024
Merged

Add feature to filter by field in the events table rows #6991

merged 26 commits into from
Sep 17, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Sep 11, 2024 •
edited
Loading

Description

The native Discover plugins has the feature to add a filter in one of the results rows. We need to implement this feature as well in the new events table.

Issues Resolved

#6977

Evidence

Peek.2024-09-11.11-28.mp4

Test

Navigate to the "Events" tab in any module, place the cursor over a cell, and click on "+" or "-" to filter by this value.

Unit tests

image

image

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli linked an issue Sep 11, 2024 that may be closed by this pull request
Add feature to filter by field in the events table rows #6977
Closed
@guidomodarelli guidomodarelli changed the base branch from master to 4.9.1 September 11, 2024 14:29
@guidomodarelli guidomodarelli force-pushed the enhancement/6977-add-feature-to-filter-by-field-in-the-events-table-rows branch from c818f53 to e15982c Compare September 11, 2024 14:29
@guidomodarelli guidomodarelli self-assigned this Sep 11, 2024
@guidomodarelli
refactor: Update default pagination options and sorting columns
f57bceb
@guidomodarelli
feat: Add tsconfig.json for main plugin
61296c3
@guidomodarelli
style: Remove unnecessary white-space and formatting
9e1f3f3
@guidomodarelli
style: Simplify function parameters and formatting
4088177
@guidomodarelli
style: Remove unnecessary whitespace and fix formatting
c6451dc
@guidomodarelli
style: Update quotes and remove unnecessary line breaks
7d36ad5
@guidomodarelli
style: Update pagination to use default setting
24b4272
@guidomodarelli
feat: Add function to get cell actions in data grid
41eafb0
@guidomodarelli
feat: Add filtering functionality to data grid
26626a6
@guidomodarelli
feat: Add filters and setFilters to data grid props
e635f97
@guidomodarelli
refactor: Simplify arrow function parameters and formatting
35ede56
@guidomodarelli
refactor: Update code formatting for better readability
4390051
@guidomodarelli
docs: Update CHANGELOG.md
ca0da16
@guidomodarelli
Add cell filter actions to data grid component
61f9cde
@guidomodarelli
Add tests for cell filter actions functions
dc4e4da
@guidomodarelli
Refactor data grid service to improve column mapping
ca45d7b
@guidomodarelli
Refactor data-grid-service.ts for better readability
566af35
@guidomodarelli
Refactor parseData to handle generic source type
8bd52ea
@guidomodarelli
Update getFieldFormatted function parameters types
db2a1f8
@guidomodarelli
Fix Prettier issues
e90ceab
@guidomodarelli guidomodarelli force-pushed the enhancement/6977-add-feature-to-filter-by-field-in-the-events-table-rows branch from 3626401 to e90ceab Compare September 12, 2024 17:37
@JuanGarriuz JuanGarriuz self-requested a review September 13, 2024 08:59
@JuanGarriuz
Copy link
Member

Test

image

@Machi3mfl Machi3mfl self-requested a review September 16, 2024 12:45
asteriscos
asteriscos requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: 🔴

Please check that the buttons don't seem to work after changing the page.

Peek 2024-09-16 19-33

image

Machi3mfl
Machi3mfl approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
Test: ✅

Screenshot 2024-09-16 at 16 15 51 Screenshot 2024-09-16 at 16 15 35

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 46.02% ( 400 / 869 )
Branches 41.97% ( 157 / 374 )
Functions 44.01% ( 136 / 309 )
Lines 46.22% ( 398 / 861 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 13.75% ( 4069 / 29588 )
Branches 9.13% ( 1765 / 19312 )
Functions 13.45% ( 959 / 7130 )
Lines 13.92% ( 3965 / 28468 )

JuanGarriuz
JuanGarriuz approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@asteriscos asteriscos merged commit 500def5 into 4.9.1 Sep 17, 2024
5 checks passed
@asteriscos asteriscos deleted the enhancement/6977-add-feature-to-filter-by-field-in-the-events-table-rows branch September 17, 2024 08:24
@asteriscos asteriscos mentioned this pull request Sep 23, 2024
Closed
1 task
@gdiazlo gdiazlo mentioned this pull request Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@asteriscos asteriscos asteriscos approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz approved these changes

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add feature to filter by field in the events table rows
4 participants
@guidomodarelli @JuanGarriuz @Machi3mfl @asteriscos