Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter deprecated actions #7042

Merged
merged 4 commits into from
Oct 1, 2024
Merged

Filter deprecated actions #7042

merged 4 commits into from
Oct 1, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Oct 1, 2024 •
edited
Loading

Description

The goal of this pull request is to filter deprecated / not listed actions in Wazuh API /security/actions endpoint.

Issues Resolved

Closes #7031

Test

  • Go to Server management -> Security -> Policies
  • Click on the policy that has the security:revoke action
  • Check it doesn't throw an exception

Peek 2024-10-01 12-41

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos self-assigned this Oct 1, 2024
@asteriscos asteriscos linked an issue Oct 1, 2024 that may be closed by this pull request
Security policies exception #7031
Closed
Tostti
Tostti previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
image

CR 🟢

LGTM

guidomodarelli
guidomodarelli reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test 🟢
image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

guidomodarelli
guidomodarelli approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Main plugin code coverage (Jest) test % values
Statements 14.09% ( 4177 / 29637 )
Branches 9.18% ( 1771 / 19290 )
Functions 13.74% ( 985 / 7166 )
Lines 14.28% ( 4075 / 28523 )

@asteriscos asteriscos merged commit 23c8dc5 into 4.10.0 Oct 1, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7031-security-policies-exception branch October 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidomodarelli guidomodarelli guidomodarelli approved these changes

@Tostti Tostti Tostti left review comments

Assignees

@asteriscos asteriscos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security policies exception
3 participants
@asteriscos @guidomodarelli @Tostti