Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid filter hiding when adding too many of them #7077

Merged
merged 7 commits into from
Oct 17, 2024
Merged

Avoid filter hiding when adding too many of them #7077

merged 7 commits into from
Oct 17, 2024

Conversation

guidomodarelli
Copy link
Contributor

@guidomodarelli guidomodarelli commented Oct 7, 2024 •
edited
Loading

Description

Avoid filter hiding when adding too many of them

Issues Resolved

#7049

Evidence

Peek.2024-10-07.08-43.mp4
Peek.2024-10-09.08-42.mp4

wazuh-dashboard-plugins/plugins/main/public/styles/media-queries.scss

Lines 128 to 132 in 5d9a1fc

@media only screen and (max-width: 574px) {
.globalFilterGroup__wrapper-isVisible {
margin-top: -6px;
}
}

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@guidomodarelli guidomodarelli self-assigned this Oct 7, 2024
@guidomodarelli guidomodarelli mentioned this pull request Oct 7, 2024
Open
14 tasks
This was linked to issues Oct 7, 2024
Improve the events page #7049
Open
Avoid filter hiding when adding too many of them #7078
Closed
@guidomodarelli guidomodarelli removed a link to an issue Oct 7, 2024
Improve the events page #7049
Open
14 tasks
@JuanGarriuz JuanGarriuz self-requested a review October 8, 2024 09:56
JuanGarriuz
JuanGarriuz previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@JuanGarriuz JuanGarriuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests 🟢

Grabacion.2024-09-25.165509.mp4

CR 🟢

asteriscos
asteriscos requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peek 2024-10-08 13-07

@guidomodarelli guidomodarelli mentioned this pull request Oct 15, 2024
Closed
@chantal-kelm chantal-kelm self-requested a review October 15, 2024 19:04
chantal-kelm

This comment was marked as resolved.

Sign in to view

@chantal-kelm chantal-kelm self-requested a review October 15, 2024 19:15
chantal-kelm

This comment was marked as resolved.

Sign in to view

@chantal-kelm chantal-kelm self-requested a review October 15, 2024 20:43
chantal-kelm
chantal-kelm approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@chantal-kelm chantal-kelm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grabacion.de.pantalla.2024-10-15.a.la.s.5.40.23.p.m.mov

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

Main plugin code coverage (Jest) test % values
Statements 14.11% ( 4174 / 29579 )
Branches 9.23% ( 1778 / 19259 )
Functions 13.81% ( 986 / 7139 )
Lines 14.3% ( 4071 / 28465 )

asteriscos
asteriscos approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@asteriscos asteriscos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR 🟢
Test: 🟢

Peek 2024-10-17 10-54

@asteriscos asteriscos merged commit d80e3c9 into 4.10.0 Oct 17, 2024
5 checks passed
@asteriscos asteriscos deleted the bug/7049-avoid-filter-hiding-when-adding-too-many-of-them branch October 17, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asteriscos asteriscos asteriscos approved these changes

@chantal-kelm chantal-kelm chantal-kelm approved these changes

@JuanGarriuz JuanGarriuz JuanGarriuz left review comments

Assignees

@guidomodarelli guidomodarelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid filter hiding when adding too many of them
5 participants
@guidomodarelli @asteriscos @chantal-kelm @JuanGarriuz @Desvelao