Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove event tables from dashboards #7086

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Remove event tables from dashboards #7086

merged 3 commits into from
Oct 11, 2024

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Oct 9, 2024 •
edited by Desvelao
Loading

Description

This pull request removes the data grid from Threat hunting > Dashboard, GitHub > Panel (drilldowns) and Office 365 > Panel (drilldowns).

Issues Resolved

Closes #7083

Test

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos linked an issue Oct 9, 2024 that may be closed by this pull request
Improve dashboards performance #7083
Closed
2 tasks
@asteriscos asteriscos marked this pull request as ready for review October 9, 2024 15:53
@asteriscos asteriscos mentioned this pull request Oct 9, 2024
Closed
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Main plugin code coverage (Jest) test % values
Statements 13.83% ( 4069 / 29419 )
Branches 9.16% ( 1765 / 19250 )
Functions 13.5% ( 959 / 7101 )
Lines 14% ( 3965 / 28306 )

@Machi3mfl Machi3mfl self-requested a review October 9, 2024 20:08
@Desvelao
Copy link
Member

Desvelao commented Oct 10, 2024 •
edited
Loading

Test

🟢 Chrome ![app_threat-hunting](https:/user-attachments/assets/86f19480-2a4b-450b-8b09-d197a65b5a4e) ![image](https:/user-attachments/assets/0022451c-2493-4e52-8bbe-e27954d6a94b) ![image](https:/user-attachments/assets/9e6a014a-805f-42cb-9210-3f3186a7d8af) ![image](https:/user-attachments/assets/b9539d94-ecb6-480e-915e-edd1da065437) ![image](https:/user-attachments/assets/5119e0b8-98cc-4997-a7ef-e9cca9c54b4e) ![image](https:/user-attachments/assets/4c96f044-42f6-47a0-ae92-26bd5ea4b0f7) ![image](https:/user-attachments/assets/18adb864-8915-4e02-8d96-6d46cb2717de) ![image](https:/user-attachments/assets/01b71652-44f5-42df-9b62-22039ada1b81) ![image](https:/user-attachments/assets/4eeba213-fe39-43b8-82e2-db1d472e6c32)
🟢 Firefox ![image](https:/user-attachments/assets/e89e4df1-8de2-482b-a7eb-0600caad130f) ![image](https:/user-attachments/assets/180a5b08-c30d-4e31-b8da-a2406ef61bc8) ![image](https:/user-attachments/assets/4ea269d7-6a7d-4d73-b7e3-b8b63e8a09b5) ![image](https:/user-attachments/assets/6786f249-3e83-4c43-9702-d34f506b5b7d) ![image](https:/user-attachments/assets/92f3cd42-aefb-45de-afa5-bc0bb9aca67f) ![image](https:/user-attachments/assets/fc61531a-1e47-4cce-aa07-c3493d80c1f8) ![image](https:/user-attachments/assets/9a32fbf7-55ef-4a94-b2ba-1da31dbfb6f6) ![image](https:/user-attachments/assets/08614832-9447-486d-aaae-e607cef53e83) ![image](https:/user-attachments/assets/2dad201e-3f40-4713-8c8f-23409dd9d2ad) ![image](https:/user-attachments/assets/f5bf46ee-12f0-4b87-a73f-f84a845e44c9)

Machi3mfl
Machi3mfl approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Machi3mfl Machi3mfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test: ✅
CR: ✅

Screenshot 2024-10-10 at 8 54 57 AM Screenshot 2024-10-10 at 8 54 39 AM Screenshot 2024-10-10 at 8 50 22 AM

Tostti
Tostti approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@Tostti Tostti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test:
image
image
image

Test 🟢
CR 🟢

LGTM

@Desvelao Desvelao changed the title Remove data grid from Threat hunting dashboard Remove event tables from dashboards Oct 11, 2024
@Desvelao Desvelao merged commit c3559de into 4.9.1 Oct 11, 2024
5 checks passed
@Desvelao Desvelao deleted the enhancement/7083-improve-dashboard-performance branch October 11, 2024 09:57
@Tostti Tostti mentioned this pull request Oct 14, 2024
Closed
@asteriscos asteriscos mentioned this pull request Oct 16, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Machi3mfl Machi3mfl Machi3mfl approved these changes

@Tostti Tostti Tostti approved these changes

Assignees

@asteriscos asteriscos

@Desvelao Desvelao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve dashboards performance
4 participants
@asteriscos @Desvelao @Machi3mfl @Tostti