Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dashboard nested fields filtering #4425

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Aug 31, 2022

Description

In the dashboards, nested fields were not properly identified and because of this, the query results didn't work as expected. To fix it we added the index pattern information to the query building methods, so the field information can be retrieved and analyzed to structure the query object.

Closes #4430

@asteriscos asteriscos self-assigned this Aug 31, 2022
@asteriscos asteriscos added the 4.4 label Aug 31, 2022
@asteriscos asteriscos linked an issue Aug 31, 2022 that may be closed by this pull request
@asteriscos asteriscos marked this pull request as ready for review August 31, 2022 16:11
@Mayons95
Copy link
Contributor

Mayons95 commented Sep 5, 2022

TR ✔️
LGTM !

Screenshot from 2022-09-05 15-36-51
Screenshot from 2022-09-05 15-36-39
Screenshot from 2022-09-05 15-35-08

@Mayons95 Mayons95 self-requested a review September 5, 2022 18:40
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Screenshot

image

Copy link
Member

@AlexRuiz7 AlexRuiz7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asteriscos asteriscos merged commit 850646e into 4.4-7.10 Sep 8, 2022
@asteriscos asteriscos deleted the fix/nested-fields-dashboard-filtering branch September 8, 2022 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

The backport to 4.4-1.2-wzd failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-1.2-wzd 4.4-1.2-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-1.2-wzd
# Create a new branch
git switch --create backport-4425-to-4.4-1.2-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 850646e58c9cf6ee74538af23d0a2cf7b0655df3
# Push it to GitHub
git push --set-upstream origin backport-4425-to-4.4-1.2-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-1.2-wzd

Then, create a pull request where the base branch is 4.4-1.2-wzd and the compare/head branch is backport-4425-to-4.4-1.2-wzd.

github-actions bot pushed a commit that referenced this pull request Sep 8, 2022
* Added missing index pattern to queries

* Added changelog

(cherry picked from commit 850646e)
AlexRuiz7 added a commit that referenced this pull request Sep 8, 2022
Fixed dashboard nested fields filtering (#4425)

* Added missing index pattern to queries

* Added changelog

(cherry picked from commit 850646e)

Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: Álex <[email protected]>
AlexRuiz7 pushed a commit that referenced this pull request Sep 8, 2022
* Added missing index pattern to queries

* Added changelog

(cherry picked from commit 850646e)
AlexRuiz7 added a commit that referenced this pull request Sep 8, 2022
Fixed dashboard nested fields filtering (#4425)

* Added missing index pattern to queries

* Added changelog

(cherry picked from commit 850646e)

Co-authored-by: Federico Rodriguez <[email protected]>
@Mayons95 Mayons95 mentioned this pull request Dec 7, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards don't filter properly nested fields
4 participants