Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent name to the deployment command #4739

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Oct 21, 2022

Description

With this development now the user can add a name to the agent using the deployment wizard of the UI.

This name is defined using the variable WAZUH_AGENT_NAME, which is set using the interactive deployment wizard, and added to the installation command.

Issues Resolved

#4573

Evidence

  • When the user has permissions
con.acceso.mp4
  • When the user does not have permissions
con.acesso.mp4

Test

  1. Go to the agent deployment wizard.
  2. Set a name for the agent using the input for this purpose.
  3. Check that the variable WAZUH_AGENT_NAME has been correctly set and added to the deployment command.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@chantal-kelm chantal-kelm linked an issue Oct 21, 2022 that may be closed by this pull request
@chantal-kelm chantal-kelm self-assigned this Oct 21, 2022
@chantal-kelm chantal-kelm changed the title Variable Wazuh Name Variable WAZUH_AGENT_NAME Oct 21, 2022
@chantal-kelm chantal-kelm marked this pull request as ready for review October 24, 2022 16:33
@chantal-kelm chantal-kelm requested a review from a team as a code owner October 24, 2022 16:33
@Mayons95 Mayons95 self-requested a review October 24, 2022 18:17
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
TR: ✔️

Screenshot from 2022-10-24 15-31-54

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ☑️ with comments
Test: ✅

@AlexRuiz7 AlexRuiz7 marked this pull request as draft October 27, 2022 14:25
@AlexRuiz7
Copy link
Member

Changed back to draft as there are lots of issues to solve still.

@Machi3mfl Machi3mfl requested review from Machi3mfl and asteriscos and removed request for Machi3mfl October 27, 2022 16:08
Copy link
Member

@asteriscos asteriscos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good job ✔️

@Machi3mfl Machi3mfl marked this pull request as ready for review October 27, 2022 16:33
@AlexRuiz7 AlexRuiz7 changed the title Variable WAZUH_AGENT_NAME Add agent name to the deployment command Oct 28, 2022
@AlexRuiz7 AlexRuiz7 merged commit 548265d into enhancement-4205-redesign-of-add-agent-page Oct 28, 2022
@AlexRuiz7 AlexRuiz7 deleted the enhancement-4573-add-agent-name-in-the-form branch October 28, 2022 09:15
chantal-kelm added a commit that referenced this pull request Nov 3, 2022
* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* removing spaces, css den deshuso, unify uppercase

* removing link space

* fixed labels

* change of logic in links

* Removed snapshot to fix unit tests workflow

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Allow multiple server selection in the agent deploy section (#4737)

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* Added free option enter and cleaned code

* Refactored code and added new tests and fixed old tests

* Resolved review comments following dev style guide

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

Co-authored-by: Álex <[email protected]>

* links included

* remove messages, add and remove links

* update

* Revert "Allow multiple server selection in the agent deploy section" (#4775)

Revert "Allow multiple server selection in the agent deploy section (#4737)"

This reverts commit b60fd49.

* changes

Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* removing spaces, css den deshuso, unify uppercase

* removing link space

* fixed labels

* change of logic in links

* Removed snapshot to fix unit tests workflow

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Allow multiple server selection in the agent deploy section (#4737)

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* Added free option enter and cleaned code

* Refactored code and added new tests and fixed old tests

* Resolved review comments following dev style guide

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

Co-authored-by: Álex <[email protected]>

* links included

* remove messages, add and remove links

* update

* Revert "Allow multiple server selection in the agent deploy section" (#4775)

Revert "Allow multiple server selection in the agent deploy section (#4737)"

This reverts commit b60fd49.

* changes

Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
(cherry picked from commit 77945e2)
github-actions bot pushed a commit that referenced this pull request Nov 3, 2022
* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* removing spaces, css den deshuso, unify uppercase

* removing link space

* fixed labels

* change of logic in links

* Removed snapshot to fix unit tests workflow

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Allow multiple server selection in the agent deploy section (#4737)

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* Added free option enter and cleaned code

* Refactored code and added new tests and fixed old tests

* Resolved review comments following dev style guide

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

Co-authored-by: Álex <[email protected]>

* links included

* remove messages, add and remove links

* update

* Revert "Allow multiple server selection in the agent deploy section" (#4775)

Revert "Allow multiple server selection in the agent deploy section (#4737)"

This reverts commit b60fd49.

* changes

Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
(cherry picked from commit 77945e2)
chantal-kelm added a commit that referenced this pull request Nov 3, 2022
Redesign of add agent page (#4647)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* removing spaces, css den deshuso, unify uppercase

* removing link space

* fixed labels

* change of logic in links

* Removed snapshot to fix unit tests workflow

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Allow multiple server selection in the agent deploy section (#4737)

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* Added free option enter and cleaned code

* Refactored code and added new tests and fixed old tests

* Resolved review comments following dev style guide

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

Co-authored-by: Álex <[email protected]>

* links included

* remove messages, add and remove links

* update

* Revert "Allow multiple server selection in the agent deploy section" (#4775)

Revert "Allow multiple server selection in the agent deploy section (#4737)"

This reverts commit b60fd49.

* changes

Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
(cherry picked from commit 77945e2)

Co-authored-by: Chantal Belén kelm <[email protected]>
chantal-kelm added a commit that referenced this pull request Nov 3, 2022
Redesign of add agent page (#4647)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* removing spaces, css den deshuso, unify uppercase

* removing link space

* fixed labels

* change of logic in links

* Removed snapshot to fix unit tests workflow

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Allow multiple server selection in the agent deploy section (#4737)

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* Added free option enter and cleaned code

* Refactored code and added new tests and fixed old tests

* Resolved review comments following dev style guide

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

Co-authored-by: Álex <[email protected]>

* links included

* remove messages, add and remove links

* update

* Revert "Allow multiple server selection in the agent deploy section" (#4775)

Revert "Allow multiple server selection in the agent deploy section (#4737)"

This reverts commit b60fd49.

* changes

Co-authored-by: Maximiliano Ibarra <[email protected]>
Co-authored-by: Álex <[email protected]>
Co-authored-by: Maximiliano Ibarra <[email protected]>
(cherry picked from commit 77945e2)

Co-authored-by: Chantal Belén kelm <[email protected]>
chantal-kelm added a commit that referenced this pull request Nov 10, 2022
…wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
chantal-kelm pushed a commit that referenced this pull request Nov 11, 2022
…wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
(cherry picked from commit d178752)
Machi3mfl added a commit that referenced this pull request Nov 14, 2022
…wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
(cherry picked from commit d178752)
Machi3mfl added a commit that referenced this pull request Nov 14, 2022
…wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
(cherry picked from commit d178752)
Machi3mfl added a commit that referenced this pull request Nov 14, 2022
…n the agent deployment wizard (#4861)

Add cluster's IP and protocol as suggestions in the agent deployment wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
(cherry picked from commit d178752)
Machi3mfl added a commit that referenced this pull request Nov 14, 2022
…he agent deployment wizard (#4862)

* Add cluster's IP and protocol as suggestions in the agent deployment wizard (#4776)

* section deploy new agent in progress

* tabSystemD and tabSysV

* section deploy a new agent done

* cleaning code

* cleaning code

* test

* CHANGELOG

* code cleaning

* design for when a user selects an obsolete system version

* code cleanup

* changed macOS for macOS and updated the macOS version view

* development with information update provided by ci cd

* applying some of the new changes that the ci cd team sent us today

* delete

* updating information sent by ci/cd on operating systems, commands, etc.

* logic of displaying message to rare operating systems and redirecting them to documentation

* logic of displaying message to rare operating systems and redirecting them to documentation

* wazuh protocol variable

* Ordered OS buttons in deploy new agent steps

* Replaced input server address

* Testing signed commits

* Added server address component isolated from register-agent component

* Added test for multiple nodes rendered in combobox

* Added wazuh manager multiple ips in command definition

* Refactored and cleaned code

* Added unit test

* Updated CHANGELOG

* Added default option and paste only name in combo tag

* variable of deployment wazuh protocol

* merge 4.4-7.10

* Added free option enter and cleaned code

* removing spaces, css den deshuso, unify uppercase

* Refactored code and added new tests and fixed old tests

* removing link space

* fixed labels

* Resolved review comments following dev style guide

* change of logic in links

* Added OS delimiter condition

* Added and updated unit tests

* Resolved review comments

* Removed empty file

* Removed snapshot to fix unit tests workflow

* message + error handling

* Detached getRemoteInfo request in service to ease unit testing

* Add agent name to the deployment command (#4739)

* Add variable for the agent's name

* input is cleaned if there is no data

* design input name

* Update CHANGELOG

* Resolved review comment, unused code and code format

Co-authored-by: Maximiliano Ibarra <[email protected]>

* Fixing tests

* Testing signed commit with updated email

* Fixing unverified commit

* Fixing eslint errors

* Added get remote info by node and unit tests

* Added server address and protocol behavior

* Updated Server address unit tests

* Updated and added register agent service unit tests

* Added error managment in register agent and server address component

* Updated CHANGELOG

* Fixed tests workflow

* CHANGELOG

* udpProtocol:false

* constants for repeated text

Co-authored-by: chantal.kelm <[email protected]>
Co-authored-by: Chantal Belén kelm <[email protected]>
Co-authored-by: Álex <[email protected]>
(cherry picked from commit d178752)

* Fixed unit tests snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add agent name as part of the agent deployment form
6 participants