Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limit property in wazuh-api controller #4971

Conversation

asteriscos
Copy link
Member

@asteriscos asteriscos commented Dec 7, 2022

Description

Hi team,
this PR fixes the problem that the number 500 of a request property was replaced with an HTTP status code constant.

Issues Resolved

#4969

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@asteriscos asteriscos added the 4.4 label Dec 7, 2022
@asteriscos asteriscos requested a review from a team as a code owner December 7, 2022 12:49
@asteriscos asteriscos self-assigned this Dec 7, 2022
@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.65% ( 3193 / 36906 )
Branches 4.43% ( 1271 / 28632 )
Functions 7.54% ( 691 / 9157 )
Lines 8.71% ( 3080 / 35329 )

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

✔️ code
✔️ test

I tested it by exporting to csv the rules in Manament/Rules and I got the rules.

@Desvelao Desvelao merged commit 7d66538 into 4.4-2.4-wzd Dec 14, 2022
@Desvelao Desvelao deleted the fix/replace-status-code-constant-for-a-number-4969-4.4-2.3 branch December 14, 2022 16:08
github-actions bot pushed a commit that referenced this pull request Dec 14, 2022
* Fix limir property of request

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 7d66538)
github-actions bot pushed a commit that referenced this pull request Dec 14, 2022
* Fix limir property of request

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 7d66538)
Desvelao added a commit that referenced this pull request Dec 14, 2022
* Fix limit property in wazuh-api controller (#4971)

* Fix limir property of request

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 7d66538)

* changelog: update the pr number

Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: Antonio David Gutiérrez <[email protected]>
Desvelao added a commit that referenced this pull request Dec 14, 2022
* Fix limit property in wazuh-api controller (#4971)

* Fix limir property of request

* Add changelog

Co-authored-by: Álex <[email protected]>
(cherry picked from commit 7d66538)

* changelog: update the pr number

Co-authored-by: Federico Rodriguez <[email protected]>
Co-authored-by: Antonio David Gutiérrez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace status code constant for a basic number in wazuh-api controller
3 participants