Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 4.4-2.4-wzd] Fix-commands-in-the-deploy-new-agent-section #4984

Merged
merged 8 commits into from
Dec 19, 2022
Merged

[Backport 4.4-2.4-wzd] Fix-commands-in-the-deploy-new-agent-section #4984

merged 8 commits into from
Dec 19, 2022

Conversation

chantal-kelm
Copy link
Member

@chantal-kelm chantal-kelm commented Dec 13, 2022 •
edited
Loading

Backport [9ddb5ca, 765bf37] from #4962.

@chantal-kelm chantal-kelm requested a review from a team as a code owner December 13, 2022 13:00
@chantal-kelm chantal-kelm changed the title Backport 4962 to 4.4 2.3 wzd [Backport 4.4-2.3-wzd] fix-commands-in-the-deploy-new-agent-section Dec 13, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.3-wzd] fix-commands-in-the-deploy-new-agent-section [Backport 4.4-2.3-wzd] Fix-commands-in-the-deploy-new-agent-section Dec 13, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.3-wzd] Fix-commands-in-the-deploy-new-agent-section [Backport 4.4-2.3-wzd] Fixed-commands-in-the-deploy-new-agent-section Dec 14, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.3-wzd] Fixed-commands-in-the-deploy-new-agent-section [Backport 4.4-2.4-wzd] Fixed-commands-in-the-deploy-new-agent-section Dec 14, 2022
@chantal-kelm chantal-kelm changed the title [Backport 4.4-2.4-wzd] Fixed-commands-in-the-deploy-new-agent-section [Backport 4.4-2.4-wzd] Fix-commands-in-the-deploy-new-agent-section Dec 14, 2022
@chantal-kelm chantal-kelm mentioned this pull request Dec 15, 2022
Merged
6 tasks
@chantal-kelm chantal-kelm linked an issue Dec 15, 2022 that may be closed by this pull request
Fix commands in the deploy new agent section (missing -1). #4958
Closed
Mayons95
Mayons95 previously approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@Mayons95 Mayons95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR: ✔️
LGTM

image

@github-actions
Copy link
Contributor

Code coverage (Jest) % values
Statements 8.65% ( 3195 / 36912 )
Branches 4.43% ( 1271 / 28635 )
Functions 7.54% ( 691 / 9158 )
Lines 8.72% ( 3082 / 35343 )

yenienserrano
yenienserrano approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@Mayons95 Mayons95 self-requested a review December 19, 2022 16:19
@chantal-kelm chantal-kelm merged commit b1140d0 into 4.4-2.4-wzd Dec 19, 2022
@chantal-kelm chantal-kelm deleted the backport-4962-to-4.4-2.3-wzd branch December 19, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yenienserrano yenienserrano yenienserrano approved these changes

@Mayons95 Mayons95 Mayons95 approved these changes

Assignees

@chantal-kelm chantal-kelm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix commands in the deploy new agent section (missing -1).
4 participants
@chantal-kelm @yenienserrano @Mayons95 @AlexRuiz7