-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default selected options in Deploy Agent page #5063
Conversation
Solution detailsCreated a new component called {
id: string,
label: string,
default?: boolean
} Example for Amazon Linux Behavior
Behavior evidenceScreencast.2023-01-03.12.51.21.mp4Unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR ✔️
TEST ✔️
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8c1201e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
d2f064c
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-2.4-wzd 4.4-2.4-wzd
# Navigate to the new working tree
cd .worktrees/backport-4.4-2.4-wzd
# Create a new branch
git switch --create backport-5063-to-4.4-2.4-wzd
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e71b344b598c77a0af6ea414abb721666118353c
# Push it to GitHub
git push --set-upstream origin backport-5063-to-4.4-2.4-wzd
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-2.4-wzd Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.4-7.16 4.4-7.16
# Navigate to the new working tree
cd .worktrees/backport-4.4-7.16
# Create a new branch
git switch --create backport-5063-to-4.4-7.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e71b344b598c77a0af6ea414abb721666118353c
# Push it to GitHub
git push --set-upstream origin backport-5063-to-4.4-7.16
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.4-7.16 Then, create a pull request where the |
* Added default selected options * Updated CHANGELOG * Removed unused code * Added unit tests * Cleaned imports (cherry picked from commit e71b344)
* Added default selected options * Updated CHANGELOG * Removed unused code * Added unit tests * Cleaned imports (cherry picked from commit e71b344)
Description
Added default selected options in Deploy Agent Page
Closes #5061
Testing cases
Check the auto-selected version and architecture when having only one option
Check the auto-selected OS options
Check List
yarn test:jest