Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix z-index of the menu component #5273

Conversation

yenienserrano
Copy link
Member

@yenienserrano yenienserrano commented Mar 8, 2023

Description

Change the z-index value of the Wazuh menu class so that it is displayed correctly when the navigation menu is locked.

Issues Resolved

Evidence

image

image

image

Test

  1. Open the navigation menu and then the wazuh menu.
    Should see the wazuh menu at the back of the navigation menu.

  2. Open the navigation menu, lock it and then the wazuh menu.
    Should see the wazuh menu in front of the navigation menu.

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yenienserrano yenienserrano changed the base branch from master to 4.4-2.4-wzd March 8, 2023 17:43
@yenienserrano yenienserrano self-assigned this Mar 8, 2023
@yenienserrano yenienserrano marked this pull request as ready for review March 9, 2023 09:41
@yenienserrano yenienserrano requested a review from a team as a code owner March 9, 2023 09:41
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

Code coverage (Jest) % values
Statements 8.77% ( 3239 / 36924 )
Branches 4.5% ( 1291 / 28671 )
Functions 7.63% ( 698 / 9148 )
Lines 8.83% ( 3124 / 35359 )

@Desvelao
Copy link
Member

Desvelao commented Mar 9, 2023

Wazuh dashboard

Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable

UI

Test Chrome Firefox
With undockered platform menu, open the plugin menu and this should be displayed under the platform menu 🟢 🟢
With dockered platform menu, open the plugin menu and this should be displayed over the platform menu 🟢 🟢

Details

🟢 With undockered platform menu, open the plugin menu and this should be displayed under the platform menu

Chrome - 🟢
image

Firefox - 🟢
image

🟢 With dockered platform menu, open the plugin menu and this should be displayed over the platform menu

Chrome - 🟢
image

Firefox - 🟢
image

Copy link
Member

@Desvelao Desvelao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review:

🟢 code
🟢 test #5273 (comment)

@AlexRuiz7 AlexRuiz7 changed the title Wazuh main menu is displayed when the navigation menu is locked Fix z-index of the menu component Mar 9, 2023
@AlexRuiz7 AlexRuiz7 merged commit 6459f71 into 4.4-2.4-wzd Mar 9, 2023
@AlexRuiz7 AlexRuiz7 deleted the fix-5264-wazuh-main-menu-is-not-displayed-when-the-navigation-menu-is-locked branch March 9, 2023 12:13
AlexRuiz7 pushed a commit that referenced this pull request Mar 17, 2023
* change z-index on wz-menu-popover-under

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wazuh main menu is not displayed when the navigation menu is locked
3 participants